Closed ewauq closed 8 months ago
Probably related to #159
I'm having a similar issue with the buttons showing up in Firefox (and Chrome).
Firefox console shows:
Source map error: Error: NetworkError when attempting to fetch resource. Resource URL: moz-extension://\<UID>/%20Import%20Discogs%20releases%20to%20MusicBrainz.user.js#15 Source Map URL: jquery.min.map
Same thing with the Bandcamp script:
Source map error: Error: NetworkError when attempting to fetch resource. Resource URL: moz-extension://\<UID>/%20Import%20Bandcamp%20releases%20to%20MusicBrainz.user.js#16 Source Map URL: jquery.min.map
I also launched a clean Windows Sandbox with Chrome installed and had similar source map errors. It didn't matter what extension was used (tried Violentmonkey and Tampermonkey).
Might have something to do with stuff I found while looking around:
Possible workaround I haven't tried yet:
https://github.com/webpack/webpack/issues/1194#issuecomment-402494524
Core issue seems to lead all the way back to:
WebExtensions Doesn't Find Source Maps https://bugzilla.mozilla.org/show_bug.cgi?id=1437937
@thefinalwolf Discogs changed the layout of their release pages ago, maybe this caused your problem:
@kellnerd It's possible; I'm not familiar with JavaScript and have only created a few scripts (through lots of trial and error) for sites that bugged me. I don't see errors specific to not being able to find elements though.
I'll try a few tests once I can allocate time.
@thefinalwolf You don't need to have a look at the code changes, all I wanted to say is that your problem might not be the one in this issue but the other one which has already been fixed. So you would only need to update the userscript and see if the import button shows up again.
@kellnerd Ah, I see. Yup, replacing the script with the one from #412 worked just fine. Same network error, but doesn't matter since I could still import.
Thanks for pointing this out. I wonder why this fix hasn't been merged into the main branch.
Maybe I was looking at the wrong branch. I don't GitHub much.
Never mind, it was a recent commit I didn't notice 7 days ago. Sweet.
Six year old ticket, no longer actionable. Please file a new issue for problems with the latest userscript version if necessary.
Since a recent Firefox update, the Discogs importer doesn't seem to work anymore. On Chrome everything is ok.
There is no error on the FF console. The version used on both browsers is 2017.02.25.0.