search

murdos / musicbrainz-userscripts

Collection of userscripts for MusicBrainz, by various authors
537 stars 91 forks source link

Remove extension on Bandcamp image link #180

Open CyberSkull opened 6 years ago

CyberSkull commented 6 years ago

The link to the original version of the image on the Bandcamp should avoid forcing an extension because the file returned is not always a JPEG. The extension should be dropped and _0 should be the end of the file name as that will allow Bandcamp to return the original image without any extension/filesystem confusion.

(updated per Freso!)

zas commented 5 years ago

Well, i did a quick test:

We changed from _1 to _0 in https://github.com/murdos/musicbrainz-userscripts/commit/98f69b23c692fe883112be02aad983dbf858e442#diff-4d60f77b954a4880295940617b90724e

I think we should use _1 again, most of the times it's identical, but in PNG format (but i'm not sure if it's the original or a JPEG converted to PNG).

Can you do some research about this ? I'm lacking of time atm for that.

But, i agree about the goal: let's provide the link to the best image possible.

Freso commented 5 years ago

_0 is the original image, _1 is the original image converted to PNG. (File extension doesn't matter. https://f4.bcbits.com/img/a0519591319_1.jpg also serves PNG.)

Similarly, @CyberSkull's original comment is also wrong. E.g., https://f4.bcbits.com/img/a3055846450_0.jpg serves PNG image.

CyberSkull commented 5 years ago

Feso's right. I forgot to update the bug, it's just a lot of confusion for the file system. Most software are smart enough to check the file for the type first, but we should still avoid forcing an extension.

@zas _0 gives us the original upload as far as I can see, which is sometimes JPEG, sometimes PNG.