search

murdos / musicbrainz-userscripts

Collection of userscripts for MusicBrainz, by various authors
551 stars 92 forks source link

Discogs script only partially working #413

Open morrinson opened 3 years ago

morrinson commented 3 years ago

The script fails to open the import button in the sidebar, but all the other buttons / links (for label, artist, etc. redirections to MusicBrainz) are properly showing. I've tried basically everything, log out and back in, deactivate ad blocker, change language, manually update and reinstall script, but the same behavior happens on three different computers (all with Firefox / Windows).

unknown

liftarn commented 3 years ago

I got this. bild

for https://www.discogs.com/Corona-Virus-Corona-Virus/release/4630996

morrinson commented 3 years ago

Same error message on my side with respect to this release. Regarding the original issue of this thread, it seems to have been corrected since. I leave the issue open just in case it is helpful for the issue mentioned by liftarn.

kellnerd commented 3 years ago

@liftarn The importer script interprets tracks 14.1 and 14.2 as medium 14, tracks 1 and 2, and fails because this leaves a huge gap between medium 1 and "14". Not sure whether this should be fixed in the importer because Discogs also allows subtracks to be entered properly which are then correctly parsed by the importer. But I think there has to be a general decision on how the script should deal with subtracks first:

lyz-code commented 2 years ago

@morrinson were you able to make it work? It worked for me once I clicked on a specific release. You can't import the master release

morrinson commented 2 years ago

@lyz-code Yeah it finally worked (after a fix around 31 Aug I guess). But it was not for a master, which indeed cannot be imported. The original post's screenshot was related to this page: https://www.discogs.com/release/15672190-Chui-Wan-Eye