murgo / IrssiNotifier

notifies android phones from irc private messages
Apache License 2.0
171 stars 63 forks source link

Add support for some more highlighting options (nick blacklist, pattern blacklist and "whitelist") #118

Closed turmoni closed 11 years ago

turmoni commented 12 years ago

I've added three new highlight-control options to my version of irssinotifier.pl; these are:

(I've also got rid of a few stray tabs and replaced them with spaces.)

-Dave

murgo commented 12 years ago

Thanks, I'll test and (probably) merge these some day. Not sure how oft-used these would be, but I guess options can't hurt :). Though, there's been at least one request for the blacklisting (or whitelisting, I'm not sure any more).

turmoni commented 12 years ago

Thanks; I agree that they're probably mainly going to be useful for more heavy irssi users, but they're all things I'd implemented (in a pretty hacky way) on a previous script version out of necessity. (The regex blacklisting mainly being due to having hundreds of windows of PM spam firing up a load of wget processes and pushing rather a lot of notifications to my phone.)

Now, typing this did make me realize that I hadn't quite reimplemented what I meant to, insofar as the whitelist should only apply to public messages (for my use case at least, I can't decide that this is what everyone else wants), so I've now fixed that.

murgo commented 11 years ago

Finally I've taken a look at the commits, everything looks good, so finally merging, testing and releasing. Thanks, and sorry for the wait.