search

murgo / IrssiNotifier

notifies android phones from irc private messages
Apache License 2.0
171 stars 63 forks source link

Notified of wrong message #120

Closed joanmarie closed 11 years ago

joanmarie commented 11 years ago

The message which I expected to get notified of (from workplace jabber room via irssi-xmpp): 14:34:34 >>> elima wishes joanie to recover soon

The message I actually got notified of (from #webkitgtk+): 14:24:14 <pfor> mrobinson: here?

Proof I am not making this up: :) irssinotifier

This is the first time this has happened to me, so apologies for the lack of data. If you are as surprised as I am about this, I will make some time to investigate further.

murgo commented 11 years ago

Are you using the latest script version (you can check it at https://irssinotifier.appspot.com/#profile)? This was supposed to be fixed in d810a3c001e23de57f6b85221f9c3341f35441d6 (version 6).

joanmarie commented 11 years ago

I just checked my profile page:

Irssi script status Irssi script confirmed as working and is at latest version.

I'm a relatively new user (only since December); version 6 seems like quite some time ago.

joanmarie commented 11 years ago

I'm still seeing the issue. Tonight I unloaded the script, installed the latest version, loaded the new script, and verified that I am using the latest version on the profile page: "Irssi script confirmed as working and is at latest version." I then queried myself and sent a test message. That worked as expected.

I am now using twirssi and at the moment happen to be in an almost real-time dialog via twitter. Each time a new tweet with my name on it comes in, irssinotifier sends me my test message and not the actual, on-screen, highlighted messages as expected. (Note that all the IRC channels I'm in at the moment are quiet, so I don't think irssinotifier is actually repeating messages, but just sending the most recently received IRC message which happens to be my test query.)

murgo commented 11 years ago

Let's see if I can reproduce this by installing twirssi

murgo commented 11 years ago

I'm really having trouble to get the twirssi even hilight me, I don't get any hilights from hilighted keywords nor when receiving direct tweets. Also, the twirssi_hilights setting is not there any more as the twirssi web page indicates.

Any ideas how to reproduce this bug?

murgo commented 11 years ago

I'm pretty sure this bug is related to missing hook to proper irssi signal, probably "window hilight" or some other window signal. I just can't test which one without reproducing this.

murgo commented 11 years ago

Could you try this version, if it's actually working now? The file is at https://raw.github.com/murgo/IrssiNotifier/master/Irssi/irssinotifier.pl

Message me if you need installation instructions.

Now you shouldn't get any duplicate/wrong notifications, but you don't get any "right" notifications from the twirssi/irssi-xmpp either. That's because the custom scripts actually just print the text to some window, and they don't necessarily have any concept of message, nick, channel etc.

Proper support for 3rd party scripts should be done either per-script basis (better but more work) or just send the whole printed text as the notification (could be ugly in many cases, might require work in the Android app).