murgo / IrssiNotifier

notifies android phones from irc private messages
Apache License 2.0
171 stars 63 forks source link

Highlights only work with -nick, not -word #165

Closed Zannick closed 8 years ago

Zannick commented 10 years ago

The IrssiNotifier script doesn't recognize inlined highlights (namely, those set up as -word instead of -nick) and thus never sends those notifications. The result is that I'm never notified for channel highlights because all my highlights use -word.

I use hilightwin.pl, so perhaps it could be configurable to trip notify whenever the hilight window has a new entry (other than "Day changed")?

On the other hand, hilightwin.pl can recognize -word highlights (via ($dest->{level} & (MSGLEVEL_HILIGHT))), so I should think irssinotifier.pl should be able to as well.

murgo commented 10 years ago

Yeah, it seems that word hilights doesn't work. For me, those don't even get hilighted but that just might be my theme, I've never used those...

I'm not going to integrate the script to work with hilightwin, since it's pretty pointless. Altough, IIRC, some guys have wished for being able to be notified from all messages on certain channel/window.

I'll add support for word notifications some day (pull request is a lot faster way to get this to be supported, though).

murgo commented 8 years ago

Not sure if this works as supposed based on #178.