search

murgo / IrssiNotifier

notifies android phones from irc private messages
Apache License 2.0
171 stars 63 forks source link

Fixed 'highlight' typo #188

Closed hakusdream closed 8 years ago

hakusdream commented 8 years ago

Typos in various places, including Perl server, client Java, and public-facing HTML code.

murgo commented 8 years ago

The Irssi term usually seems to be hilight instead of highlight. That's why it's written as hilight in IrssiNotifier.

Irssi command for setting highlights is /hilight. The script wouldn't even work with the spelling fixes, since the correct flag is called MSGLEVEL_HILIGHT, not MSGLEVEL_HIGHLIGHT. This is Irssi's internal workings.

In Irssi documentation it's usually called highlight though, even though all the commands and settings use hilight. See https://irssi.org/documentation/settings/.

Thus it might be best to use hilight in the script and highlight in the web page to match Irssi style, but I can't be bothered for now.

Thanks anyway.