No need to use wget when we have native perl libraries

murgo / IrssiNotifier

notifies android phones from irc private messages

Apache License 2.0

171 stars 63 forks source link

No need to use wget when we have native perl libraries #89

Closed zigdon closed 12 years ago

zigdon commented 12 years ago

Also, while we're at it, no need to verify the settings on each hilight, once should be sufficient.

murgo commented 12 years ago

Thanks for these! Going to review, merge and test when I have the time (hopefully in the next couple of days).

murgo commented 12 years ago

That LWP::UserAgent is a bit problematic, since it doesn't to be all that common (as in "the first guy that tested it didn't have it installed", he had Debian GNU/Linux 6.0). I've been trying to avoid any installation hassles as far as possible, hence the wget (it's installed practically everywhere).

Also, from quick testing I noticed that when just switching scripts from the existing to your version, the notifications stop. Not sure what's causing it yet.

murgo commented 12 years ago

Damn I suck at this Git/GitHub stuff. I've merged your changes, but since I had already merged something else before that, changes conflicted. I guess I fixed the conflicts and did the post-merge commit somehow wrong, so your name isn't showing up in the commit history, sorry about that.

Anyway, thanks for the changes. I'll probably take the LWP stuff out and switch back to wget (for reasons explained in the previous comment), but the rest is good stuff.