search

muri0031 / portfolio

0 stars 0 forks source link

Problems with the nav bar @abhaysharma #1

Open muri0031 opened 10 months ago

muri0031 commented 10 months ago

Hello Teacher, @abhaysharma I hope you are good. I almost finish the assignemt, I had my nav bar with bootstrap, I changed it in the pag Contact to make it responsive, but I don't know why it is not working, I mean when is in the desktop version, it is desplayed, and when it's in the mobile version, the button appears but doesn't display any pages.

I didn't change the index, and About page yet, because I want to make sure that it's working first in the contact page, you can check the other part if you want to compare de menus. Thank you so much!!

Regards, Karla Murillo

muri0031 commented 10 months ago

https://muri0031.github.io/portfolio/contact.html

abhaysharma commented 10 months ago

@muri0031 for the hamburger menu to work you need to add the button in your index and about page. since index and about are closer to complete I am suggesting the change for them and not contact. You will need to add the following code right after the a.navbar-brand inside your nav

 <button class="navbar-toggler" type="button" data-bs-toggle="collapse" data-bs-target="#menu" aria-controls="menu" aria-expanded="false" aria-label="Toggle navigation">
            <span class="navbar-toggler-icon"></span>
          </button>
muri0031 commented 10 months ago

I already did it but it's still not working, I don't know I delete for a little the ccs code for that part but it's not working etither. I have the same code than in the bootstrap and the button appears, but doesn't display anything

muri0031 commented 10 months ago

https://muri0031.github.io/portfolio

abhaysharma commented 10 months ago

@muri0031 I see that the menu is working now. Do you still need help?

muri0031 commented 10 months ago

No, thank you so much. I could fix it. Just one question, I finished all the assignment, I validated everything and is correct. I double checked in validator, but when I press validate css en the website, it appears so many things, but I think those aren’t errors, because In validator says that everything is correct. What can I do?

Get Outlook for iOShttps://aka.ms/o0ukef

From: Abhay Sharma @.> Sent: Sunday, December 10, 2023 7:24:45 PM To: muri0031/portfolio @.> Cc: Karlabeatriz Murillojordan @.>; Mention @.> Subject: Re: [muri0031/portfolio] Problems with the nav bar @abhaysharma (Issue #1)

You don't often get email from @.*** Learn why this is importanthttps://aka.ms/LearnAboutSenderIdentification

@muri0031https://github.com/muri0031 I see that the menu is working now. Do you still need help?

— Reply to this email directly, view it on GitHubhttps://github.com/muri0031/portfolio/issues/1#issuecomment-1849146316, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7W36GLFMOCOZPWNWDN6GZTYIZHE3AVCNFSM6AAAAABAMBSRT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBZGE2DMMZRGY. You are receiving this because you were mentioned.Message ID: @.***>

abhaysharma commented 10 months ago

@muri0031 the issues you are seeing with CSS validation are because of external libraries. You can validate your CSS file directly using this link https://muri0031.github.io/portfolio/css/main.css