search

muriplz / CreateBigContraptionsMultiloader

Create: Big Contraptions but for forge and fabric :)
1 stars 0 forks source link

Suggestion: Offload contraption NBT data to the server-side #1

Open adaliszk opened 4 weeks ago

adaliszk commented 4 weeks ago

Hey, excellent work on this so far! I want to propose a fitting idea to solve the problem and not just treat the symptoms:

With contraptions, one of the biggest and easiest pitfalls in making their NBT data large is picking a contraption up when its storage is sufficiently saturated. Each chest, barrel, or vault stores its inventory in the contraption as NBT.

A proposal to mediate the problem is to decouple the contraptions' inventory from their entity data. So, ideally, when a contraption is made, it should create its own NBT data file with the same NBT structure we have now and reference that within the entity. With that, you could overwrite access patterns to resolve the reference, filter on the server side based on the interaction, and stream over the data through multiple packets.

muriplz commented 2 weeks ago

i mean it's a great idea, but this mod is 3 mixing with 1 line of code each. I am not the best developer out there and I guess this is up for Create devs. After all this mod only fixes a vanilla bug that should have been fixed ages ago, as it can happen in Vanilla + Datapacks if you add enough recipes

adaliszk commented 2 weeks ago

If this is only "fixing" a vanilla bug, I see no point in advertising it as a Create thing with its very name. The issue on the vanilla side is the same: raising limits is not the answer; if it were, Mojang would have done it already.

I guess we could wait for 0.5.2 or 0.6 if create devs do something about it, though not sure if they will as the issue really is greed in this case 😄

muriplz commented 1 week ago

It's not a perfect fix, but it was never meant to be, this is just to get rid of kicks in my server.

The mod has Create's name because it was made due to an issue I had with the mod, and people also experience the same issue. The name reason is more due to helping users find the mod rather than trying to bring popularity and relevance to a "3 java lines" mod.

I do hope that there's some fix in the near future too 😄