search

murongqimiao / DAG-diagram

VUE plugin for DAG graph , u can use it 4 flow diagram or machine learning visualization
https://murongqimiao.github.io/DAG-diagram/#/example
MIT License
403 stars 124 forks source link

feat: my total modifications #11

Open KomeijiSatori opened 5 years ago

KomeijiSatori commented 5 years ago

This is my modification which meets my own requirements, you may not merge, just take a look :D. You may fetch my code and run for fun~ I have refactored a lot of your code. From my point of view, your code style may not be easy to read and modify, and some parts can be optimized. You may take a look at my modification, maybe there are some parts you can adopt. And I list some important modifications in my readme.md. And thank you for your effort, I have been inspired a lot from your code, you've done well~ @murongqimiao

Zheaoli commented 5 years ago

Hello bro

would you mind to split this PR into couples PRs? just make sure one PR for one thing.

And I guess maybe you should solve the file conflict fist?

KomeijiSatori commented 5 years ago

Could you resolve the conflicts first?

Hi, I started developing from commit 2e327b953947485ad35796c19464e1cdb3366356 So if you reset hard from that commit, and replace all files with my new changes, you will not see conflicts.

KomeijiSatori commented 5 years ago

Hello bro

would you mind to split this PR into couples PRs? just make sure one PR for one thing.

And I guess maybe you should solve the file conflict fist?

Thank you for your suggestions, but I actually develop from my company, and any previous commits are removed, sorry for the inconvenience. And I'm not intend to merge this pull requests because I remove some features from the origin repo. If you are interested in what I have changed, I suggest write an email to me and I will explain in detail, thanks for your interest!