Datapack issue

[benio1394]

Hello, sorry to bother you, as this is not exacly fault of your mod, but I ve tried to make a datapack to add boats from a few mods, and for some reason it doesn't work. Could you take a look at it?

{ "values": [ "#c:boats", "vinery:dark_cherry_boat", "vinery:dark_cherry_chest_boat", "meadow:pine_boat", "meadow:pine_chest_boat", "azaleawood:azalea_boat", "azaleawood:azalea_chest_boat", "desolation:charred_boat", "desolation:charred_chest_boat", "bewitchment:elder_boat", "bewitchment:elder_chest_boat", "bewitchment:juniper_boat", "bewitchment:juniper_chest_boat", "bewitchment:cypress_boat", "bewitchment:cypress_chest_boat", "bewitchment:dragons_blood_boat", "bewitchment:dragons_blood_chest_boat" ] }

[murphy-slaw]

Is the source of your datapack somewhere I could take a look at it?

[benio1394]

Unfortunably not, but I can send it to you here: unseaworthy_compatibility.zip

[murphy-slaw]

Is this datapack for 1.21? If so, Mojang changed the path from entity_types to entity_type.

I will note this in the docs.

[benio1394]

Unfortunably not, as you can see in pack.mcmeta it's for 1.20.1

[murphy-slaw]

I think I know what’s up here. You are listing boat items. This tag needs to be boat entities.

You will need to look at the mods to see how they register their boat entities. Frequently it is “modname:boat” and “modname:chest_boat”

[benio1394]

Yeah, the problem is in boat entity tag. Unfortunably, most mods use terraform for adding boats and it have strange ID build. Would it be possible to add tag for all terraform boats? It will give support to most of the mods.

[murphy-slaw]

From looking at the Terraform Boat API, it looks like the entity types are just "terraform:boat" and "terraform:chest_boat"

https://github.com/TerraformersMC/Terraform/blob/1.21/terraform-wood-api-v1/src/main/java/com/terraformersmc/terraform/boat/impl/TerraformBoatInitializer.java