search

murphy214 / nlgeojson

Fastest, simplest, vanilla Pandas DF to geojson output.
10 stars 1 forks source link

import future and import Geohash error in Python 3.* #1

Open ryanbaumann opened 6 years ago

ryanbaumann commented 6 years ago

Problem

After running pip install nlgeojson on Python 3.5 and 3.6, I get two errors:

  1. Missing package future
    • Solved via pip install future
  2. Missing package geohash
    • Solve by changing two things:
      • Make geohash folder in python/site-packages lower case geohash
      • Update __init__.py in python/site-packages/geohash to use from .geohash.

@murphy214

ref - https://github.com/mapbox/mapboxgl-jupyter/issues/24

murphy214 commented 6 years ago

https://github.com/murphy214/nlgeojson/commit/fb902684f848d37278cf3a71ed705f1c81b1445e

@ryanbaumann I updated the package decencies and install requirements, and tested 2.7 which works, however 3.x installs doesn't work due to me having two of what the installer sees as arbitrary binaries in my bin/script file. These essentially are just compiled go executables for reading geojson, I'm not super aware of best practice on this kind of stuff but I'm thinking I should upload the binaries to a service like brew and pull them down from their any ideas.

As for the other issues, I plan on doing quite a refactor tomorrow on a lot of the code breaking it up etc. this code sort of grew and never got refactored properly.