search

murphyqm / pytesimal

Model the conductive cooling of small planetary bodies with temperature-dependent material properties
MIT License
1 stars 0 forks source link

Linting core cooling #4

Closed murphyqm closed 4 years ago

murphyqm commented 4 years ago

Making sure this module adheres to PEP8; still need to fill in docstring with some data types - to do on Monday.

murphyqm commented 4 years ago

investigating issue with indexing of times_core_frozen - have been using [2] due to [0] throwing up a time of 0.0 Myr, but did not document correctly when making this change

murphyqm commented 4 years ago

times_frozen = np.where(core_frozen)[0] and times_frozen = np.where(core_frozen)[1] produce same result: core freezing initiating at 0.0 Myr when plotting clearly shows a later freezing period.

time_core_frozen = times_frozen[0] -> index has also been set to [2]. Why? Should be set to 0; causes a delay by 2 Myr in core freezing initiation.

Check repository history - implemented after results produced.

murphyqm commented 4 years ago

Verified that this has been consistent for all results produced from paper.