search

murraycu / android-galaxyzoo

This Android app lets you classify Galaxy Zoo subjects. It is available in the Google Play Store: https://play.google.com/store/apps/details?id=com.murrayc.galaxyzoo.app . Try beta versions early here: https://play.google.com/apps/testing/com.murrayc.galaxyzoo.app . See also the iPhone app for Galaxy Zoo: https://github.com/murraycu/ios-galaxyzoo/
GNU General Public License v3.0
11 stars 13 forks source link

Change Login menu item to "Log out" when the user is logged in. #18

Closed murraycu closed 9 years ago

murraycu commented 9 years ago

The "Login" menu item doesn't change after the user is logged in. This seems to have made at least one person think that the login was not successful. (There is already a brief "Logged in" message after logging in and every time you open the app, to partly help with this.)

This (awkward anyway) branch tries to change it to "Log out" when we are logged in, but the menu of the current activity doesn't get updated yet: https://github.com/murraycu/android-galaxyzoo/tree/show-log-out

Note also that there's no way to know when the login becomes invalid, for instance if the user changes their password on the website. That's a server bug that we can't do anything about in the client: https://github.com/zooniverse/Galaxy-Zoo/issues/184

murraycu commented 9 years ago

This was fixed by this commit: https://github.com/murraycu/android-galaxyzoo/commit/34a24149a9d2d2fd9e0edf3c656d37e0b3e73af0

However, due to this bug with the server, we cannot know when your login has become invalidated, for instance if you change your password, or if the server's auth key is for a limited time (as it should be): https://github.com/zooniverse/Galaxy-Zoo/issues/184