Fix order of ImpersonationLevel and TokenType in DuplicateTokenEx

murrayju / CreateProcessAsUser

Creates a process in a different Windows session

MIT License

369 stars 114 forks source link

Fix order of ImpersonationLevel and TokenType in DuplicateTokenEx #40

Closed Itja closed 2 months ago

Itja commented 8 months ago

Thanks for the great library.

The order of these two ints is wrong. This is just a minor inconvenience, as the calls have them in the correct order.

Itja commented 8 months ago

Okay, I am now having trouble getting DuplicateTokenEx to work for me when trying to duplicate the token for the current process, which made me look into the MS documentation again:

Here, the ImpersonationLevel comes before the TokenType.
In the example code in point 5 here, ImpersonationLevel comes after the TokenType.

Color me confused.

murrayju commented 2 months ago

I'm under the impression that this change is not needed. If someone has better evidence to the contrary, we can reopen.