search

murrayo / yape

yet another pButtons extractor
MIT License
11 stars 7 forks source link

Replacing os.path with Path objects #17

Open d-little opened 5 years ago

d-little commented 5 years ago

Any opinions about replacing references os.path.join calls with pathlib.Path objects?

Happy to work through and submit the pull request if there's an appetite for it. I understand this is a little bit of a do-nothing change, but it's just a personal preference. From a quick search it also removes the need for the whole os library, replaced with Path from path

https://github.com/murrayo/yape/search?q=os.path

https://www.python.org/dev/peps/pep-0428/ https://docs.python.org/3/library/pathlib.html https://treyhunner.com/2018/12/why-you-should-be-using-pathlib/

murrayo commented 5 years ago

I have no special preference either way. So happy for you to change.

Thanks

On 17 Apr 2019, at 8:56 am, d-little notifications@github.com<mailto:notifications@github.com> wrote:

Any opinions about replacing references os.path.join calls with pathlib.Path objects?

Happy to work through and submit the pull request if there's an appetite for it. I understand this is a little bit of a do-nothing change, but it's just a personal preference. From a quick search it also removes the need for the whole os library, replaced with Path from path

https://github.com/murrayo/yape/search?q=os.path

https://www.python.org/dev/peps/pep-0428/ https://docs.python.org/3/library/pathlib.html https://treyhunner.com/2018/12/why-you-should-be-using-pathlib/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/murrayo/yape/issues/17, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AJjaSJzVHe5QyKYiPshVV8nOr8IY6Kxuks5vhlUOgaJpZM4cz3Pq.