murrty / youtube-dl-gui

Download/Convert videos from websites without needing to learn command line
GNU General Public License v3.0
427 stars 45 forks source link

Unable to display non-English About dialog #169

Closed maboroshin closed 1 year ago

maboroshin commented 1 year ago

Unable to display non-English About dialog. In my environment I am getting an error when I select Russian or German etc.

An uncaught FormatException occurred and the application may resume.

Message: インデックス (0 ベース) は 0 以上で、引数リストのサイズよりも小さくなければなりません。
Message Means: The index (0-based) must be greater than or equal to 0 and smaller than the size of the argument list.

Type: System.FormatException
Source: mscorlib
Target Site: System.Text.StringBuilder AppendFormatHelper(System.IFormatProvider, System.String, System.ParamsArray)
Stacktrace:
   Place System.Text.StringBuilder.AppendFormatHelper(IFormatProvider provider, String format, ParamsArray args)
   Place System.String.FormatHelper(IFormatProvider provider, String format, ParamsArray args)
   Place youtube_dl_gui.frmAbout.LoadLanguage()
   Place youtube_dl_gui.frmAbout..ctor()
   Place youtube_dl_gui.frmMain.mAbout_Click(Object sender, EventArgs e)
   Place System.Windows.Forms.MenuItem.OnClick(EventArgs e)
   Place System.Windows.Forms.MenuItem.MenuItemData.Execute()
   Place System.Windows.Forms.Command.Invoke()
   Place System.Windows.Forms.Control.WmCommand(Message& m)
   Place System.Windows.Forms.Control.WndProc(Message& m)
   Place System.Windows.Forms.Form.WndProc(Message& m)
   Place youtube_dl_gui.frmMain.WndProc(Message& m)
   Place System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

========== OS  INFO ==========
Current Version: 3.2.3
Current Culture: Japanese (Japan)
System Caption: Microsoft Windows 10 Pro
System Version: 10.0.19045
Service Pack Major: 0
Service Pack Minor: 0
========== END INFO ==========
maboroshin commented 1 year ago

This has resolved itself. I understood. the ini file had not been updated to the new strings. This was why the error was occurring. It seems to occur with strings with arguments such as {1}.

maboroshin commented 1 year ago

https://github.com/murrty/youtube-dl-gui/issues/20