murrty / youtube-dl-gui

Download/Convert videos from websites without needing to learn command line
GNU General Public License v3.0
431 stars 44 forks source link

InitialMessage is always in English #170

Open maboroshin opened 1 year ago

maboroshin commented 1 year ago

After "save" the language selection, the dlgFirstTimeInitialMessage remains in English.

image

If "No" is selected for dlgFirstTimeInitialMessage, the following file is created. The settings in this file seem to read English strings, not Japanese.

youtube-dl-gui.ini :

[youtube-dl-gui]
LanguageFile=Japanese

In this ini, the main window in Japanese is displayed.

youtube-dl-gui.ini :

[youtube-dl-gui]
LanguageFile=Japanese
firstTime=False

After selecting Japanese and going through all the Initial Messages, the main window is in English. It seems that a re-start program is required for displaying other language. Or re-select the language. So, After the ini with only LanguageFile=Japanese is created, it is re-started and moves to the initial message, which seems to be a good.

murrty commented 1 year ago

The way that languages are handled (currently, i'm thinking about ways to change it) is that language files can be any name so it is difficult to figure out the language for the user. It would be easy to detect the culture string (ex: en-us) for the language and select the file, but I do not have the time to put this change into motion right now.