search

murrty / youtube-dl-gui

Download/Convert videos from websites without needing to learn command line
GNU General Public License v3.0
430 stars 44 forks source link

aac instead of opus #41

Closed RomanVanish closed 4 years ago

RomanVanish commented 4 years ago

Why 2.23 saves audio in aac, while its original extenstion (as it is in original video file) is opus. I compared it with 2.22 version.. So it does it in original opus...

murrty commented 4 years ago

What quality are you downloading with on both versions? I think it might have been a bug that I just fixed in commit 4dc30c6 depending on the circumstance.

RomanVanish commented 4 years ago

same options, same video sample, "best" on both versions and "no vbr"

"I think it might have been a bug that I just fixed in commit 4dc30c6 depending on the circumstance." Is it already available for download?

P.S. would really appreciate if you could also fix download from soundcloud

murrty commented 4 years ago

Here's a debug build, let me know if it helps. youtube-dl-gui.zip

RomanVanish commented 4 years ago

Unfortunately not. https://i.imgur.com/PCQxuZs.jpg https://i.imgur.com/wDWrmSl.jpg https://i.imgur.com/jYBIikW.jpg

murrty commented 4 years ago

Alright, I think I pinpointed the issue. Try this build which should solve the issue.

RomanVanish commented 4 years ago

Yes, it helps, ty.