search

murrty / youtube-dl-gui

Download/Convert videos from websites without needing to learn command line
GNU General Public License v3.0
430 stars 44 forks source link

can't cancle downloads anymore in version 2.26 #97

Closed vitalitasia closed 3 years ago

vitalitasia commented 3 years ago

hello,

sometimes the speed is very low when downloading from youtube. so cancelling and restarting the download fixes this for the most time. on version 2.26 the "cancel" button isn't working correctly. need to press it many times, sometimes it closes after a while, sometimes it crashes

murrty commented 3 years ago

I'm aware that it sometimes works/sometimes doesn't. You can close the main form to force it to stop, but it will likely say the program crashed.

murrty commented 3 years ago

So, I managed to find a way to cancel processes.

Here's the thing, yt-dlp has subprocesses (children) which assist in the download. youtube-dl does not. This implementation may be buggy while the problems get ironed out and the logic gets optimized (since its mostly copied from someone else's code from 2011).

Hopefully, it'll solve the issue without any fixes required, but that's just a dream.