feat: Reimplement imports and expose wildcards as a named node

murtaza64 / tree-sitter-groovy

Tree sitter parser for groovy

MIT License

16 stars 10 forks source link

feat: Reimplement imports and expose wildcards as a named node #15

Closed ValdezFOmar closed 3 months ago

ValdezFOmar commented 3 months ago

Make the import name much more restrictive, this helps avoid conflicts between dotted names and "." before "*" in imports.
Don't allow aliases with wildcard import, choose one or the other.
Write more test cases.

I used this docs as a reference: https://www.groovy-lang.org/structure.html

https://github.com/nvim-treesitter/nvim-treesitter/pull/6979

clason commented 3 months ago

ping @murtaza64

murtaza64 commented 3 months ago

Thanks, I'm on holiday so might not be able to merge straight away but will take a look soon!

murtaza64 commented 3 months ago

PR looks good. Do you need to update the highlights in nvim-treesitter for groovy too? If so, I'd appreciate if you could update the highlights here too!