both file name based and embeded work now for one single image

[adigherman]

Coded both file name based rendering (the cross origin request issue will be present) and embedding the file data into the html file.

[muschellij2]

This doesn't seem to work for 2 images passed in rather than just 1. Did you test 2 images?

[adigherman]

For now it works with only one image per papaya instance (see my commit comment), I'll have to work on adding the code to handle multiple ones. I did some some tests with series of images (manually created the html file) and it seemed that papaya is only displaying the last image in the series. Can you please confirm that or let me know what I'm missing?

Sent from my iPhone

On Apr 12, 2017, at 11:59 PM, John Muschelli notifications@github.com<mailto:notifications@github.com> wrote:

This doesn't seem to work for 2 images passed in rather than just 1. Did you test 2 images?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/muschellij2/papayaWidget/pull/2#issuecomment-293773504, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARa8mdqHKqCUt6XlhHtcTVtCFfgPIcl5ks5rvZ25gaJpZM4Mu0GO.

[muschellij2]

We just have to make multiple variables with data for the number of images and then put then into the array in encodedImages. I don't know how to do this in your jquery though: https://github.com/rii-mango/Papaya/issues/71

John

On Thu, Apr 13, 2017 at 7:16 AM, Adi G notifications@github.com wrote:

For now it works with only one image per papaya instance (see my commit comment), I'll have to work on adding the code to handle multiple ones. I did some some tests with series of images (manually created the html file) and it seemed that papaya is only displaying the last image in the series. Can you please confirm that or let me know what I'm missing?

Sent from my iPhone

On Apr 12, 2017, at 11:59 PM, John Muschelli <notifications@github.com< mailto:notifications@github.com>> wrote:

This doesn't seem to work for 2 images passed in rather than just 1. Did you test 2 images?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ muschellij2/papayaWidget/pull/2#issuecomment-293773504, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ ARa8mdqHKqCUt6XlhHtcTVtCFfgPIcl5ks5rvZ25gaJpZM4Mu0GO.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/muschellij2/papayaWidget/pull/2#issuecomment-293861562, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBnrqLptz73dy_4h27cvkYKgabDxGMgks5rvgP4gaJpZM4Mu0GO .

[adigherman]

I'll put some more work into this next week.

Initial tests for the Neuroconductor nightly pulls are promising. Just a few more screws to tighten tomorrow.

Adi

Sent from my iPhone

On Apr 13, 2017, at 10:24 PM, John Muschelli notifications@github.com<mailto:notifications@github.com> wrote:

We just have to make multiple variables with data for the number of images and then put then into the array in encodedImages. I don't know how to do this in your jquery though: https://github.com/rii-mango/Papaya/issues/71

John

On Thu, Apr 13, 2017 at 7:16 AM, Adi G notifications@github.com<mailto:notifications@github.com> wrote:

For now it works with only one image per papaya instance (see my commit comment), I'll have to work on adding the code to handle multiple ones. I did some some tests with series of images (manually created the html file) and it seemed that papaya is only displaying the last image in the series. Can you please confirm that or let me know what I'm missing?

Sent from my iPhone

On Apr 12, 2017, at 11:59 PM, John Muschelli notifications@github.com<mailto:notifications@github.com< mailto:notifications@github.com>> wrote:

This doesn't seem to work for 2 images passed in rather than just 1. Did you test 2 images?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ muschellij2/papayaWidget/pull/2#issuecomment-293773504, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ ARa8mdqHKqCUt6XlhHtcTVtCFfgPIcl5ks5rvZ25gaJpZM4Mu0GO.

- You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/muschellij2/papayaWidget/pull/2#issuecomment-293861562, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBnrqLptz73dy_4h27cvkYKgabDxGMgks5rvgP4gaJpZM4Mu0GO .

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/muschellij2/papayaWidget/pull/2#issuecomment-294069971, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ARa8mXnG5scQT8AfVn-2L856nX-AgxGSks5rvtjFgaJpZM4Mu0GO.

[muschellij2]

Sounds great - thanks for the work - let's connect via email over the week.

John

On Thu, Apr 13, 2017 at 10:35 PM, Adi G notifications@github.com wrote:

I'll put some more work into this next week.

Initial tests for the Neuroconductor nightly pulls are promising. Just a few more screws to tighten tomorrow.

Adi

Sent from my iPhone

On Apr 13, 2017, at 10:24 PM, John Muschelli <notifications@github.com< mailto:notifications@github.com>> wrote:

We just have to make multiple variables with data for the number of images and then put then into the array in encodedImages. I don't know how to do this in your jquery though: https://github.com/rii-mango/Papaya/issues/71

John

On Thu, Apr 13, 2017 at 7:16 AM, Adi G <notifications@github.com<mailto: notifications@github.com>> wrote:

For now it works with only one image per papaya instance (see my commit comment), I'll have to work on adding the code to handle multiple ones. I did some some tests with series of images (manually created the html file) and it seemed that papaya is only displaying the last image in the series. Can you please confirm that or let me know what I'm missing?

Sent from my iPhone

On Apr 12, 2017, at 11:59 PM, John Muschelli <notifications@github.com< mailto:notifications@github.com>< mailto:notifications@github.com>> wrote:

This doesn't seem to work for 2 images passed in rather than just 1. Did you test 2 images?

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ muschellij2/papayaWidget/pull/2#issuecomment-293773504, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ ARa8mdqHKqCUt6XlhHtcTVtCFfgPIcl5ks5rvZ25gaJpZM4Mu0GO.

- You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/muschellij2/papayaWidget/pull/ 2#issuecomment-293861562, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBnrqLptz73dy_ 4h27cvkYKgabDxGMgks5rvgP4gaJpZM4Mu0GO .

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ muschellij2/papayaWidget/pull/2#issuecomment-294069971, or mute the threadhttps://github.com/notifications/unsubscribe- auth/ARa8mXnG5scQT8AfVn-2L856nX-AgxGSks5rvtjFgaJpZM4Mu0GO.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/muschellij2/papayaWidget/pull/2#issuecomment-294071408, or mute the thread https://github.com/notifications/unsubscribe-auth/ABBnrtEt1v-tEEZ0wvpCSsK6EAFeWs9Lks5rvttugaJpZM4Mu0GO .