search

muse-sequencer / muse

MusE is a digital audio workstation with support for both Audio and MIDI
https://muse-sequencer.github.io/
Other
634 stars 67 forks source link

Fix build with ninja 1.12.0, fix #1276 #1277

Closed BSDKaffee closed 1 month ago

terminator356 commented 1 month ago

We've had these build race conditions several times in the past, sometimes requiring mind-bending extensive rewrites. Been quiet for several years though.

Thanks very much for the PR and tracking the problem. I will review the other headers and remove the one I mentioned and possibly some others. Sometimes it's just old code that one way or another got lost in time.

terminator356 commented 1 month ago

OK I also removed 'ctrlcombo.h' and 'midisyncimpl.h'. Hope it don't break anything. We're lucky these are simple fixes not requiring rewrites like other building race conditions we've had :-)

Try it out, let me know if any trouble. Thanks. Tim.