search

muse / Captain

A dynamic lemonbar script written almost entirely in bash.
MIT License
49 stars 5 forks source link

Add toggle for Force Docking #5

Closed ufUNnxagpM closed 8 years ago

ufUNnxagpM commented 8 years ago

Added a few lines to allow the force docking option to be toggled via captainrc.

muse commented 8 years ago

Boolean comparison is done without quotes, the same goes for creating the initial value.

[key]=false

[[ $var = false ]]

The script is written in bash, and [[ is the standard. It'd like to see that in the if statement as well. You could also consider not using if and going with [[ $var = bool ]] && echo "-d". I'll leave that to you though.

tl;dr Unquote the booleans and use [[ instead of [.

muse commented 8 years ago

Looks good, thanks!