search

musement / eslint-plugin

@musement/eslint-plugin repository
ISC License
6 stars 1 forks source link

Add eslint promise plugin #7

Closed aurelienlair closed 3 years ago

aurelienlair commented 3 years ago

WHAT Add ESlint promise plugin

WHY because it can be useful to have it but most importantly it can bring added value by reinforcing code quality when using promises

REMARKS eslint-plugin-promise@5.1.0 requires a peer of eslint@^7.0.0 so it's fine with what is defined in the peer dependencies

przemkow commented 3 years ago

Hi @aurelienlair! Thanks for opening a PR! About adding a new package to dependencies I'm not sure if this is exactly what you are looking for. Adding a dependency to package.json does not add it automatically to your project, all dedicated configs should be updated as well to make it work.

About the dependency - I'm not sure if it is required by all projects. I think in that case the better idea would be to install it directly in your project and extend your .eslintrc instead of updating @musement/eslint-plugin