Enhancement - Add Song Lyrics

museofficial / muse

🎧 a self-hosted midwestern Discord music bot that doesn't suck

MIT License

914 stars 242 forks source link

Enhancement - Add Song Lyrics #603

Open Zagrthos opened 2 years ago

Zagrthos commented 2 years ago

What about a command that posts the Lyrics in an Embedd? Like if you type "/lyrics" it loads the current Lyrics from Genius or some other website and posts it.

Maybe with an extra Option for "/play" so that the bot post the Lyrics automatically at the start of the new song?

codetheweb commented 2 years ago

I don't currently plan on adding this myself but would be willing to take a look at a high-quality PR implementing this.

Plecra commented 1 year ago

Hi! Id like this feature for a new guild I'm putting together. Id like to run a few things by you abt my implementation:

it'll be designed to be used as a live activity, animated in time with playback. For singing along to music together :)
Able to source lyrics from multiple backends, with the first implementation being through yt closed captions. A Musixmatch implementation would give us high quality lyrics for most songs, and LRC/srt loading is also a good future feature. Here's some prior art
I expect karaoke mode will also need special synchronization for the audio to compensate for the input latency on international calls. I'll hopefully be able to implement this as direct connections between the sound server and users. Because this puts a higher bandwidth requirement on the host, it'll be configurable.

It shouldn't be any trouble to add a /lyrics command on top of this is it's desirable.

Zagrthos commented 1 year ago

After I looked myself into adding this feature via various APIs I (for myself) come to an end that it's not really possible to do. The main issue will be the paywall by the lyric providers because they only give you a specific percentage of text for free - if you want more you have to pay (Copyright stuff and so on). And some other provides don't even provide the ability to grab the lyrics from the API.

Didn't tried the thing you provided via reddit though but as of now I'm saying this is not doable.

codetheweb commented 1 year ago

@Plecra if you can get any of that working, that'd be super cool. I didn't think of using YT CCs before; I suspect they're somewhat low quality on most tracks but would be a good start.

ContinualDissapointment commented 1 week ago

I was interested in seeing exactly how other projects in GH implemented lyrics command features, found that another project used to use public api urls until feb 2023 when they actually started using "rlyrics": "^2.0.1", would rlyrics be a suitable package for this feature? I really love music bots having lyrics functionality.