search

muserr / pe

0 stars 0 forks source link

Outdated API used for modules. #6

Open muserr opened 4 years ago

muserr commented 4 years ago

image.png

The module CS1020 is no longer offered in NUS.

I should be prevented from adding modules that I can no longer assign a grade to.

nus-pe-bot commented 4 years ago

Team's Response

We have an "update" command for that purpose. And we also don't think not up-to-date database which can be updated should be considered a bug anyway. Rejecting this as a bug.

To add on the module still exists within NUSMODs database (look at CS2030 prerequisites on nusmods.com) thus our version allows for addition of any modules so long as it had been offered in NUS.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I would like to thank the developers for their response and politely disagree with the following:

The Developers stated in their response: "our version allows for addition of any modules so long as it had been offered in NUS". This statement shows a flaw in the product design and will be further elaborated later.

The Developers provided the analogy of "the module still exists within NUSMODs database (look at CS2030 prerequisites on nusmods.com)". Unfortunately, this is a poorly chosen analogy.

image.png

(Taken from nusmods.com)

Kindly notice that NUSMODs database does not have a hyperlink to the CS1020, because it is no longer an offered module in NUS.

CS1020 is still displayed as part of CS2030 preclusion as current students who have previously completed CS1020 are not allowed to take CS2030. But that does not mean students who are currently interested in taking CS1020 are able to take CS1020.

If users were to key in CS1020 in the search box, they will not be able to find the module being offered:

image.png

(Taken from nusmods.com)

In addition, according to the UserGuide:

image.png

(Team's UserGuide, pg 1)

If an aim of ModPlan is to help NUS students keep track of current and future modules to be taken, there should at least be a disclaimer stating that the database is not up to date which allows users to add modules that are currently no longer offered at NUS.

If we look at the Expect Anomalous Behaviour section:

image.png

(Team's UserGuide, pg 19)

We notice that there is a disclaimer for the cap module feature for not taking into account of the prerequisites/preclusions.

However, the lack of validation for relevance of modules in the ModPlan database is not stated.

It is a design flaw when users are still able to enter and add modules that no longer exists, as this results in users not being able to utilise other features of ModPlan. Such as to add their grades, timetable and CAP features for that non-existent module.

Hence, resulting in a flaw in how the product works.