search

muserr / pe

0 stars 0 forks source link

Program crashes when updating modules. #7

Open muserr opened 4 years ago

muserr commented 4 years ago

image.png

When showing module, I can see a few.

Yet when updating modules, the program crashes. I am unable to recover from the program crash.

image.png

nus-pe-bot commented 4 years ago

Team's Response

Based on the provided information, this bug cannot be reproduced even after testing on all three popular OS platforms such as Windows, Linux and Mac.

Looking at the stack trace provided, the error was thrown Gson's fromJson function, hence it was not thrown from the RequestData class, thus it appears that the issue lies in parsing the downloaded .json data back into usable Java Objects.

Would require additional information for replication, since if the data file was changed in anyway, that would indeed cause errors observed.

Items for the Tester to Verify

:question: Issue response

Team chose [response.CannotReproduce]

Reason for disagreement: I thank the developers for their response and respectfully disagree with the following:

"… since if the data file was changed in anyway, that would indeed cause errors observed." This statement shows that the error is reproduceable.

According to the developer's response: "… thus it appears that the issue lies in parsing the downloaded .json data back into usable Java Objects.".

Because of the tight coupling and dependency between the data files and update module feature, ensuring that the data files are valid is extremely important.

Furthermore, the UserGuide or Developer guide failed to state what happens to the update module feature should there be an issue with the parsing of .json data.

Also, "… since if the data file was changed in anyway, that would indeed cause errors observed." contradicts and was absent in what was mentioned in the Team's PPP:

image.png

(Team's UserGuide, pg 13)

A ModBadRequestStatus will not be thrown with regard to the validity of data files. There was no mention of how the data file if changed will affect the update module feature.

Furthermore, there was no mention that there will be enhancements to the update module made in V2.0:

image.png

(Team's UserGuide, pg 19)

Thus, the above shows an unfortunate oversight when designing the Update Module feature resulting in a bug.