Refactoring + unit tests

[ButenkoT]

1. Tools: JavaScript, unit tests (tape?)

2. It is good to learn why unit tests are important and same time refactor your code and learn to not be afraid of deleting code and rewriting it.

3. 2 levels:

   In 1st level we will have 2 files

   • file with unit tests

• files with messy JS code - with a bunch of smelly code (duplication, magic numbers, spaghetti code, huge functions etc) On the beginning of the introduction show everyone that tests are passing, the task will be to refactor and clean code (without checking on unit tests) after work will be done run tests and see how many fails. This is one of the ways we can show importance of unit tests.

  In 2nd level we also will have 2 files

• file for unit tests
• file for js code Task will be to actually write some coding tasks with unit tests (TDD).

4. We need a help with this workshop, all ideas and editions, suggestions are welcomed.

5. It will require upper beginner level in JS.

@ronaldotijucas @mutsdagit @maggie-mu @rbychiang @ReenaRajani @kksy

[kksy]

Hi Tanya, I think this would be a great idea! I found that a lot of workshops out there talk about coding functionality, but not much on testing and writing clean code. Has work started with this?

Questions

• Should files be separated according to the code smell or just one file with mixed code smells?

Suggestions

• a presentation on why we do testing and refactoring
• overview of the testing framework chosen
• we can use common coding problems like FizzBuzz
• perhaps for an advanced level, we can do something on mocking and stubbing?

[ReenaRajani]

@kksy, regarding your question on one file or seperate file per code smell, i think it would be better to have mixed code smells in one file. But depending on the complexity of the code smell we can move it to a new file if required.

A similar approach is followed in the coding dojo sessions, but what we do is take already existing katas and work on them..

And thanks for your suggestions :) Mocking and Stubbing is a good idea !!

[ButenkoT]

@kksy Thank you for suggestions. We still didn't start any work with this one. Regarding your question I think we can start with 4 files in total as described and then move on if we need any more.

Splitting code for files is also a part of refactoring - can be the last step of part 1, for example.