search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.3k stars 2.66k forks source link

[MU4 Task] Rearrangement of UI for 'Snapping' and Toggle for Beam snapping #10114

Open Tantacrul opened 2 years ago

Tantacrul commented 2 years ago

Task description This is a pretty simple reorganisation we've made after recognising that the 'Snapping' setting in the properties panel is global, not unique to each element.

We've also added a toggle to allow users to disable snapping of beams by 0.25 sp.

Link to document: https://www.dropbox.com/s/n5nifhn4afcjieo/Snapping_Improvements_Dec_2001_V01%20copy.pdf?dl=0

image

Assets on Figma.

Tantacrul commented 2 years ago

Not sure if this needs UI work or not. Even if it does, it is a super simple task.

cbjeukendrup commented 2 years ago

Shouldn't the buttons at the bottom of that dialog say OK/Cancel instead of Yes/No?

Tantacrul commented 2 years ago

@cbjeukendrup You're right. My oversight

Nick-Mazuk commented 2 years ago

PR https://github.com/musescore/MuseScore/pull/10130 adds a style parameter to toggle the beam grid snapping.

Tantacrul commented 2 years ago

Since this includes a few string changes, I've moved this to Alpha 2. Let me know if this is a tough change at all. My understanding is that the parameters already exist. This would just hook them up in a more comprehensible way for the user.

cbjeukendrup commented 2 years ago

I'm planning to work on this. As I discussed with Simon, the implementation of beam snapping needs to be changed a bit: currently, it happens in the layout engine, but we agreed that it should happen in the UI layer and that the snapping options should be app-wide settings, like in MU3.

Tantacrul commented 2 years ago

I'm going to bump this to 4.x

I think we need to focus on issues, and I don't think I can justify a day or two being spent on this issue.