search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.32k stars 2.66k forks source link

[MU4 Task] [GP] Display percussion correctly #10379

Closed alexpavlov96 closed 6 months ago

alexpavlov96 commented 2 years ago

Task description Display percussion correctly

Problems:

  1. Crashes (49 and 57) are swapped Current: Screenshot 2022-01-25 at 23 22 11

Expected: Screenshot 2022-01-25 at 23 23 05

  1. China (52) has no 'roof' Current: Screenshot 2022-01-25 at 23 24 28

Expected: Screenshot 2022-01-25 at 23 24 00

  1. Ride edge (59) is wrong (looks the same as ride bell 53) Current: Screenshot 2022-01-25 at 23 25 25

Expected: Screenshot 2022-01-25 at 23 25 03

alexpavlov96 commented 2 years ago

waiting for https://github.com/musescore/MuseScore/issues/10684 to implement "China (52)"

abariska commented 2 years ago

@alexpavlov96 Please, pay attention, that Ride bell and Ride (edge) note icons is not are not fixed: Capture 2022-04-18_08-03-29_PM Capture 2022-04-18_08-01-32_PM

Tantacrul commented 2 years ago

@lengthwave - might be worth keeping an eye on this, I think.

lengthwave commented 2 years ago

I recommend we do not import as GP displays, but transform imported GP scores to how we display. This would use the same transformation on import that was discussed for marching percussion.

Tantacrul commented 2 years ago

It's not going to be possible to coordinate this without someone overlooking it. @lengthwave - I'd suggest you keep an eye on these PR's. @alexpavlov96 - you should check with @lengthwave to make sure we don't alter MuseScore to use bad defaults.

abariska commented 6 months ago

The issue expected result is deprecated. Will be definitely fixed by @zacjansheski in scope of the percussion refactoring