[MU4 Issue] Input cursor on tablature (TAB) staves is smaller than in MU3

[DmitryArefiev]

Describe the bug Input cursor on tablature (TAB) staves is smaller than in MU3

Expected behavior Cursor should be the same as in MU3

Platform information macOS, Windows, Linux

[jatinAgarwala]

Hello! I would like to try working on this issue if it's still open

[RobFog]

It’s all yours. 😊

[Tantacrul]

Any movement on this?

[somethingstarted]

i'm looking for it but I can't find it. been peaking through the code trying to familiarize myself with musescore last few days. what is the highlighter called in the program? and what would be a good file that i can start my search in?

i've been looking in \src\engraving\internal\engravingconfiguration.cpp and \src\engraving\libmscore\fret.cpp

but i haven't found the blue highlighter yet. i was thinking about making an IF fret number is 1 character, leave width as is, and if it's 2 characters (like in the example) make it x percent larger or whatever but i wont know if that's a good idea or not till i find where it's at and am able to figure out how to preview/compile programs with cmakes (i've only done VS solutions so far)

gonna watch some tutorials on previewing/compiling cmakes and i think once i figure that out, it'll make this much easier and faster for me

edit: so far no luck in me getting cmake and qt to work in either visual studio 2022 or vs code. i'll keep tinkering with it until something works and poking around the source to get more familiar with it. but if cbjeukendrup did want to point us in the right direction that would be helpful to either me or anyone else who wanted to take a stab at it

[Tantacrul]

Maybe @cbjeukendrup might be able to help?

[cbjeukendrup]

@somethingstarted In MuseScore 4 (master branch), the code for the note input cursor is in src/notation/view/noteinputcursor.cpp (and the methods that are called from there).

You might want to compare it with MuseScore 3 (3.x branch), where the code seems to be in PositionCursor::paint.

Tip: I wouldn't recommend to compile the 3.x branch, but just download the ZIP from GitHub and open it in Visual Studio Code, which is enough to browse the code. I'd also keep it in a separate folder, because when you switch between 3.x and master, you need to delete your build folder so that everything needs to be re-compiled, which takes long, so therefore I don't recommend it.

Compiling in Qt Creator might be a bit easier and is documented here: https://github.com/musescore/MuseScore/wiki/Compile-in-Qt-Creator

Alternatively, you can try to use Visual Studio, for which we have some documentation here, but this documentation is mainly about the 3.x branch and thus possibly outdated for master: https://musescore.org/en/handbook/developers-handbook/compilation/compile-instructions-windows-visual-studio#2._Building

[somethingstarted]

ight. i got it* working. properly starting on this issue now.

*the qt debugger.

[Tantacrul]

@somethingstarted - cool. If it works well, we might throw it in the patch release. If not, the next patch (if we need it) or 4.1

[somethingstarted]

I think i committed correctly. I made a quick patch for it, but i want to do more on it later.

• i added a thing to make it easy and quick to change the blue box's size in the code.

should i continue with my idea to make it so that it changes sizes, or has the ability to be resized differently if there's a 1 digit fret (0-9) or 2 digit fret (10+) or put that idea on the shelf?

[somethingstarted]

2 quick things-

I think it's ready now,

I'm hoping i did everything right, should just be noteinputcursor.cpp on the commit. that's the only file I made any changes to.

[DmitryArefiev]

@somethingstarted I've tried https://github.com/musescore/MuseScore/actions/runs/4052287331 and don't see a difference with master - the cursor is still not so wide as in MS3

[somethingstarted]

Hey, i'm still working on it. I'm new to Git and am having someone help me. we deleted my old fork, and that caused this to show as "closed" but i am determined to get the thing working.

[zacjansheski]

@cbjeukendrup @somethingstarted is there a way to get this across the finish line?

[cbjeukendrup]

@somethingstarted It looks like you closed your PR (https://github.com/musescore/MuseScore/pull/16209). What was the reason for that? And would you still like to work on this issue, or should we ask someone else?

[somethingstarted]

@cbjeukendrup someone rightly, politely, pointed out that my push req was a bandaid and not a fix to the root of the problem, and then i realized i was way in over my head and needed to work on smaller, less complex projects to get better at c++ before trying to contribute here in a meaningful way.

[jessicahalvorsen]

Hi @cbjeukendrup!

Has this issue been solved or I could I give it a try?

[cbjeukendrup]

@jessicahalvorsen Hi! This one is still available!

[jessicahalvorsen]

@cbjeukendrup great thanks! I will start working on it!