search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.22k stars 2.64k forks source link

[MU4 Issue] Tablature Guitar "Edit Staff Type" menu not saving #10964

Closed Tegze closed 2 years ago

Tegze commented 2 years ago

Describe the bug The "Fret Marks" and "Note Values" sections of "Edit Staff Type" for guitars doesn't save settings.

To Reproduce Steps to reproduce the behavior:

  1. Create a new score
  2. Add a guitar with tablature (e.g., "Electric Guitar (tablature)")
  3. Select a measure and right-click
  4. Click "Staff/part properties..."
  5. Under "Staff properties" click "Advanced style properties..."
  6. Make a change under "Fret Marks" or "Note Values"
  7. Click "OK"
  8. Click "Apply"
  9. Click "OK"
  10. Repeat 3-5
  11. Observe no settings under "Fret Marks" or "Note Values" was saved

Expected behavior Settings inside of the "Fret Marks" and "Note Values" should be saved.

Screenshots image

Platform information Windows 10

Additional context All settings inside of the "Edit Staff Type" window will save except items under "Fret Marks" and "Note Values". Setting a template does not keep the set template inside the dropdown after clicking "OK", unsure if this is the intended behavior though.

Only tested on Electric and Acoustic tablature guitars. Issue doesn't occur for instruments without this menu (e.g., Piano).

DmitryArefiev commented 2 years ago

Good catch! Thanks for logging this!

This is important option for tab staves.

DmitryArefiev commented 2 years ago

https://user-images.githubusercontent.com/90187801/160883520-09cec58b-0a1e-4fa0-8088-b0177955678f.mp4

miiizen commented 2 years ago

I don't know if anyone has already fixed this, but I've just had a quick look and got this working - didn't notice anyone was assigned, apologies!

RomanPudashkin commented 2 years ago

I don't know if anyone has already fixed this, but I've just had a quick look and got this working - didn't notice anyone was assigned, apologies!

I can assign it to you if you have a solution

DmitryArefiev commented 2 years ago

Fixed in #11100

DmitryArefiev commented 2 years ago

@Tegze Seems to be fine. Can you check on your side as well please? To be sure I didn't miss anything.

Thanks!

Tegze commented 2 years ago

@DmitryArefiev Looks good! Working for me on Windows 10 master-67b7102.

DmitryArefiev commented 2 years ago

Cool! Thank you!