musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.39k stars 2.68k forks source link

Rename "MuseScore_General_HQ" sound font to "MS Basic" #11492

Closed Tantacrul closed 2 years ago

Tantacrul commented 2 years ago

Task description Hear me out...

One of the awkward things about our new mixer is that we've necessarily needed to keep each track quite narrow. As a result, some VST and sound font titles get truncated (a very common issue across plenty of DAWs and other notation apps).

In the case of MuseScore_General_HQ (which is now our default), I feel we can't have a situation where this is what people are greeted with when they first open the app:

image

Or possibly:

image
RobFog commented 2 years ago

"MS Jojo-Schmitz" is probably best.

quinnouyang commented 2 years ago

Especially for 3rd-party names, what if we add a hover tooltip? (Assuming it doesn't deviate much from the design practices.)

Tantacrul commented 2 years ago

We should do a tool tip but I'd say we leave that for a later release. Trying to lock things down now as much as possible.

MarcSabatella commented 2 years ago

Good call. I feel like I’ve noticed similar opportunities elsewhere but of course I can’t think of any at the moment.

Jojo-Schmitz commented 2 years ago

"MS General HQ" would probably fit too

Tantacrul commented 2 years ago

I think 'HQ' is redundant now, since that it is the default.

RobFog commented 2 years ago

I think 'HQ' is redundant now, since that it is the default.

For the many users who will be updating from MuseScore 3, an FAQ could be: "Which of the previous default soundfonts is this?" Maybe this question could be handled in version 4's release announcement.

Tantacrul commented 2 years ago

Actually, I've always wondered how many users actually realised you can update to MuseScore_General_HQ, given how hidden the option to update it is. Lemme create a poll...

Tantacrul commented 2 years ago

Let's see how this pans out. My prediction is that 'I did not know about this' will get over 70%.

My reasoning is that the place it is installed from is very hidden and very few users ever read user manuals. https://twitter.com/Tantacrul/status/1521069078018142209

However, my predictions tend to be more one-sided than reality. Let's see!

Tantacrul commented 2 years ago

Also posted the same poll here: https://www.youtube.com/c/musescore/community

quinnouyang commented 2 years ago

I, for one, did not know about this:D Though I've been using the ASO soundfont for years...

MarcSabatella commented 2 years ago

Without seeing the result of the poll, I'd also expect a significant number of people saying "I heard about it, tried to install it, but got an error and gave up". Because this basically stopped working a year or two ago when the timeout for the download got shortened in the code, and most people don't have internet connections fast enough. So the only reliable way to get this now is not through the resource manager, but by finding the magic location you can download the file from directly then installing it manually.

Tantacrul commented 2 years ago

Well, a lot of people have responded and the result is actually worse than I expected.

image image
DmitryArefiev commented 2 years ago

Implemented in #12398

@Tantacrul Only one thing, the scores created in MU4 with MuseScore_General will not have a sound at first opening (after merging #12398). The user should change MuseScore_General to MS Basic (in every mixer channel) and then playback works fine. This should be done only on time. That's OK?

(Scores from MU3 don't have that problem)

Tantacrul commented 2 years ago

Um. I don't understand.

Tantacrul commented 2 years ago

We definitely cannot require users to go to the mixer to change anything when opening a score from MS3. We just need to change the name of the soundfont. It should then just be called 'MS Basic' and require no set up at all.

It is literally a rename only - of the soundfont we are already using.

DmitryArefiev commented 2 years ago

The issue I described above is about scores created in MU4 (in previous builds) You have a score created in master build with MuseScore_General and if open it in build #12398 you need to change MuseScore_General to MS Basic manually in Mixer to have a sound. That's the issue.

Scores from MU3 playback fine

Tantacrul commented 2 years ago

Oh, well in that case, it's fine :D

Sorry! I was quite rushed + confused

DmitryArefiev commented 2 years ago

Oh cool!