search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.17k stars 2.64k forks source link

[MU4 Issue] Restart required to change language #12379

Open HemantAntony opened 2 years ago

HemantAntony commented 2 years ago

Describe the bug When you change the language in Preferences, only this dialog's strings are being updated. The rest of the software does not update its strings. However, once you restart MuseScore, all strings get updated

To Reproduce Steps to reproduce the behavior:

  1. Go to Preferences
  2. Click on the dropdown
  3. Select German (Deutsch)
  4. Only the dialog's strings get updated

Expected behavior All strings should be updated

Screenshots

https://user-images.githubusercontent.com/88136054/178742109-ad6ff7f4-fa7d-4ec8-a4b1-d9790d0db6d1.mp4

Platform information

Additional context I'm running MuseScore on Qt Creator

HemantAntony commented 2 years ago

@Tantacrul This seems important

cbjeukendrup commented 2 years ago

Probably we need to do things like https://doc.qt.io/qt-5/qtquick-internationalization.html#7-use-qt-tr-noop-for-translatable-data-text-strings Just annoying, making the code more verbose, but doable.

Also: Dutch = Nederlands German = Deutsch 😉

HemantAntony commented 2 years ago

Oh sorry! Edited it now :)

igorkorsukov commented 2 years ago

@Tantacrul Maybe it's better to suggest to the user to restart the application? The language is rarely changed. And dynamic updating is not easy, a lot of additional code, from time to time something will not be updated ... (because there is no centralized solution, in each case we need to provide your own solution)

Tantacrul commented 2 years ago

@Tantacrul Maybe it's better to suggest to the user to restart the application? The language is rarely changed. And dynamic updating is not easy, a lot of additional code, from time to time something will not be updated ... (because there is no centralized solution, in each case we need to provide your own solution)

I have no problem with this as a solution for 4.0.

igorkorsukov commented 2 years ago

@cbjeukendrup FYI

cbjeukendrup commented 2 years ago

Not actual anymore, since we decided to require a restart after changing or updating the language

Jojo-Schmitz commented 2 years ago

That's really bad. It was a very nice feature of MU3 to be aboe to do this.

cbjeukendrup commented 2 years ago

@Jojo-Schmitz I quite agree, but language changing appeared to cause so many problems that we had to make this decision, just because solving those problems would be another big task causing delay. But personally, I do keep the possibility open that we will come back to this in a 4.x release.

What's really bad about it IMHO, is that it blocks us from letting the user choose a language in the "Getting started" dialog. It would mean that when you just start MuseScore for the first time and choose your language, you're told to restart it again, which is quite bad UX. So unfortunately, no language dropdown in the first launch dialog.

frfancha commented 1 year ago

Changing language for non English speaker is not "rare", it is actually quite frequent to switch to English to follow instructions from the forum (English forum being by far the most useful and reactive one). And when doing so you're typically in the middle of an "issue" so having to restart MuseScore and re-put yourself in the issue state is pretty annoying. Or before submitting topic to the forum to be able to report things using English interface of MuseScore

Jojo-Schmitz commented 1 year ago

It is not just users, also those who give support (like me). Super annoying to have to restart MuseScore just for that, and twice.