search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.22k stars 2.64k forks source link

[MU4 Issue] Text boxes have no limits #13289

Open PetJer opened 2 years ago

PetJer commented 2 years ago

Describe the bug Text boxes can have unlimited amounts of text.

Examples

Score title: The program starts running slower and can't display the name in the tab too_much_text

Palette element name: Text goes out of the bubble palette_element_text_overflow

Palette name: Abbreviates the full name to just "..." and overflows the bubble on adding elements. palette_name_overflow

Fix

Text boxes should have a limited amount of characters / If there is too much text it should display it with some characters and three dots "..." at the end.

Platform information

wizofaus commented 2 years ago

Can you explain what you mean by a "text box"? It'd be great if you stuck to the template for filling out a bug report, thanks!

cbjeukendrup commented 2 years ago

@wizofaus As you see, just all kinds of text fields across the program. In some cases we might need to add a maximum amount of characters in input fields, in other cases we should tell QML to limit the number of lines to some maximum and elide text as appropriate.

(Aside, I don't see how sticking to the issue template could have made this clearer; to me it's perfectly fine. The template is okay for most bug reports, but doesn't work well in all cases.)

wizofaus commented 2 years ago

I literally still have virtually no idea how the poster got the screenshots posted, or have any idea what they were actually trying to do, or expected to see. Maybe I'm just stupid....

PetJer commented 2 years ago

@wizofaus, actually, thanks for asking! I was writing a more detailed explanation of the issue, but then I found up while I was recreating it that there's a specific reason why it doesn't display text (missing tab name and "..." abbreviation examples). It's because of entering text with new lines to text fields. Sorry for not explaining it again, I'll do it better in the new issues.

@cbjeukendrup you understood me correctly, but I was wrong. Musescore actually does abbreviate text correctly with "...", but fails when new lines are present. The bubble and add button still overflow using text without new lines, though. I'll make a new issue for new lines being able to be in text fields and the overflow problems. Should I still make a new issue (or better edit this?) for too much text, because it's still a problem for rendering on score (first example)?

Sorry, I was sloppy, my bad!