musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.11k stars 2.62k forks source link

The offset spin boxes need to be visible when adjusting position of object with keyboard arrows #13627

Open rgreen5 opened 1 year ago

rgreen5 commented 1 year ago

Deleted. The next entry is a better opening post.

rgreen5 commented 1 year ago

IMV, this is a regression in usabilty from MS3.

In MS3, you just click on an object (say text) and the Inspector immediately opens, displaying the numerical values of X and y offset values in the Element section.

ms3_inspector

You can then immediately start adjusting the position of the object with the keyboard arrows while keeping an eye on the counter values of the offsets in the Inspector.

However in MS4 to do the same thing, you have to (1) click on the object, (2) click on Appearance (3) click on the object again and (4) press Escape,

So it takes 4 steps in MS4 to do what it takes one step to do in MS3!

You can check the issue using the attached example. Try to move the text object in measure 2 with the up keyboard arrow while keeping the "Appearance" tab open.

move_text.zip

MarcSabatella commented 1 year ago

I'm not understanding. Why would you click on the object again after clicking Appearance, or press Escape? For me the spin boxes work perfectly right away, sin't that the whole point of going to the properties panel - to actually use the spinboxes? Having to perform an extra operation just to move focus to the panel I just opened for the purpsoe of using the spinboxes would make no sense.

I agree it's a drag to need to open Appearance just to access those spinboxes, but aside from that I'm not seeing any other regression here.

rgreen5 commented 1 year ago

Isn't that the whole point of going to the properties panel - to actually use the spinboxes?

Or you may wish to use the keyboard arrow keys to move the object to an exact position by using the offset counter readings.

MarcSabatella commented 1 year ago

You might indeed, but I suspect that’s less common than than actually using the spin boxes for that sort of precision. Plus of course you might want keyboard of the other controls. It would be bad to make the more common use cases harder.

Having a way to show the offset without interfering with keyboard focus would be preferable to breaking normal keyboard navigations.

rgreen5 commented 1 year ago

Having a way to show the offset without interfering with keyboard focus would be preferable to breaking normal keyboard navigations.

That would suit me.

Eism commented 1 year ago

I think you are wrong.

Our navigation system works in such a way that when a popup(or dialog) is opened, all focus is transferred to this popup. Because of it, the user can start navigating inside the popup by clicking any arrow(even if no element inside the popup has received focus). It seems to me that this is more understandable to the user than the fact that when the pop-up is open, the arrows will navigate through the elements inside the score, but when Escape is pressed, the pop-up should close.

rgreen5 commented 1 year ago

Hopefully the new title will make the issue clearer.

oMrSmith commented 1 year ago

I'm not saying this with any anger, but popups inside an inspector get me absolutely lost, especially if the little arrow doesn't even point to where the popup originates from:

image

oMrSmith commented 1 year ago

I think drop down menus, would have been the far better solution.

https://user-images.githubusercontent.com/78870770/218873252-a19d2fed-c8af-4043-bdc3-379eb02651d8.mp4

MarcSabatella commented 1 year ago

What version is that? Neither 4.0.1 nor current nightlies have an arrow like that for staff text properties; it's a simple button that opens a separate dialog.

SteveBlower commented 1 year ago

I think this is related #12842

oMrSmith commented 1 year ago

Marc, the arrow is not a button, it is a visual indicator, supposed to point to the button, which opens the pop-up. However in this case the arrow points to nowhere:

https://user-images.githubusercontent.com/78870770/218982234-a97eca39-3640-422c-b4c5-1100ede187cc.mp4

In the following case, the arrow makes sense although in my view a dropdown menu would still be clearer and much more consistent:

image

MarcSabatella commented 1 year ago

What I am saying is, I don't see an arrow at all. I only see a button. There also seems to be a typo in your version there ("ext" instead of "text". Arte you sure this is an actual released version of MuseScore?

Here's how it looks for me:

image

Even if I change to the GB language as it seems you are using, I don't get those errors:

image

MarcSabatella commented 1 year ago

Anyhow, this also seems entirely unrelated to the issue at hand. I recommend starting a thread on the Support forum to see if anyone else can reproduce these strange behaviors you are seeing.

oMrSmith commented 1 year ago

What I am saying is, I don't see an arrow at all.

That's super strange. Just to be sure I downloaded the last nighlty, even reset my preferences and still: I'm seeing what, that you don't see.