search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
11.99k stars 2.58k forks source link

[MU4 Issue] Crash when selecting Roland Cloud VST (all instruments and effects) #16144

Open henkdegroot opened 1 year ago

henkdegroot commented 1 year ago

Describe the bug I have several Roland Cloud VST instruments and when I select one of them MS crashses. The musescore log file indicates the following message: (log data generated with 4.1) 2023-07-14T07:55:52.563 | WARN | 10756 | VstSynthesiser | setupSound: Not supported!! 2023-07-14T07:55:52.565 | ERROR | main_thread | VstModulesRepository | pluginModule: Unable to find vst plugin module, resourceId: JD-800 2023-07-14T07:55:56.678 | INFO | 10756 | VstAudioClient | setUpProcessData: BusIndex: 0 2023-07-14T07:55:56.678 | INFO | 10756 | VstAudioClient | setUpProcessData: BusType: Main 2023-07-14T07:55:56.678 | INFO | 10756 | VstAudioClient | setUpProcessData: BusFlag: DefaultActive 2023-07-14T07:55:56.678 | INFO | 10756 | VstAudioClient | setUpProcessData: 0 active input buses, activating default bus

Indicating it can't find the module, which is odd MS did show the module and allowed me to select it in the mixer. Sometimes is takes 1-2 seconds before it crashes but most of the time the crash is instantly after selecting the instrument. I don't think the unable to find vst plugin is the cause of the crash, the crash seems to happen when the plugin activated.

To Reproduce Steps to reproduce the behavior:

  1. Start a new score and select an instrument
  2. Open the mixer and select a Roland Cloud Instrument
  3. Crash

Expected behavior No crash.

Screenshots If applicable, add screenshots to help explain your problem.

Platform information

**Additional data Attached zip file contains the log file and dmp file generated using the latest master (self) build. MuseScore_230718_214620.zip

DmitryArefiev commented 1 year ago

@henkdegroot We have a crash report when using SRX KEYBOARDS from Roland. Do you have it as well to check on your side?

henkdegroot commented 1 year ago

Unfortunately my subscription does not have access to the SRX KEYBOARDS. I have tested the following: image

When I select any of these, MS crashes.

henkdegroot commented 1 year ago

Does this information help?

https://github.com/juce-framework/JUCE/commit/598748c8250df7e1c4f9a4dba29b1eb5549f7d97

DmitryArefiev commented 1 year ago

Does this information help?

juce-framework/JUCE@598748c

Don't know.. I'm not a developer. Maybe @RomanPudashkin can help

DmitryArefiev commented 1 year ago

Unfortunately my subscription does not have access to the SRX KEYBOARDS. I have tested the following: image

When I select any of these, MS crashes.

I've installed SRX KEYBOARDS, SRX WORLD and ZENOLOGY FX, they all crash on my side too. That probably happens with all Roland Cloud VSTi or VSTe

henkdegroot commented 4 months ago

Just have tried running MS in Debug using Qt Creator and found the application is crashing as a similar place in the code as mentioned in: https://github.com/juce-framework/JUCE/commit/598748c8250df7e1c4f9a4dba29b1eb5549f7d97

MS4-debug-vst

Hope this helps to get someone to investigate/resolve this.

Another interesting comment in the juce code line 2262-2263 is the fact they mention:

// Some plug-ins don't present their parameters until after the IO has been // configured, so we need to jump though all these hoops again

Perhaps another tip for this. I am happy to help out testing changes....I tried making a change to the code but did not really understand what /how to make the change as done in the juce code.