musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.18k stars 2.64k forks source link

[MU4 Issue] Nashville Numbers Rendering Modifiers incorrectly with chords_jazz.xml #16220

Open wongjoel opened 1 year ago

wongjoel commented 1 year ago

Describe the bug Nashville Numbers render correctly with chords_std.xml, but when switching to chords_jazz.xml, the font size of chord modifiers (slash, sus, minor, etc.) is extremely small.

To Reproduce Steps to reproduce the behavior:

  1. Create new file
  2. Enter Nashville Numbers with modifiers such as minor, sus or slash (Add -> Text -> Nashville Number)
  3. Change Style to Jazz (Format -> Style -> Chord Symbols -> Jazz)
  4. See error

Expected behavior Chord modifiers should be sized according to the Chord, same as when using the default chord style in chords_std.xml

Screenshots Behaviour with chords_std.xml: chords_std

Behaviour with chords_jazz.xml: chords_jazz

Platform information

Additional context I suspect this is a problem with chords_std.xml, since chords_std.xml works just fine, but I can't work out where the file sets the size of the chord modifiers.

zacjansheski commented 1 year ago

A bit easier to reproduce, must have to do with the MuseJazz style:

  1. Open Template - Jazz - Jazz lead sheet
  2. Insert Nashville Number with "sus" modifier
MarcSabatella commented 1 year ago

My first reaction (as the person who originally implemented most of this) was that I was surprised the appearance setting (standard/jazz/custom) affected Nashville numbers at all. Most things about XML files is really specific to chord symbols. But I guess somehow I did manage to get it to work in a reasonable way in MU3 (at least not as obviously terrible), and this is definitely a regression.

That said, I am not convinced what MU3 did was actually good either. While it is presumably simple to just fix the regression, it is at least worth considering giving Nashville their own rendering rules. Which for now could be just what is in chord_std.xml, and thus completely ignored the chord symbol style settings. And then if/when we add customizable rendering rules for chord symbols, we could have separate customizable rules for Nashville.

As far as where the problem is happening, this line seems potentially suspect to me - not that it's obviously wrong, just that it clearly affects size and it was added post-MU3:

https://github.com/musescore/MuseScore/blame/114ccdc996d4f0ae0871dc46849eeed56c05f2f2/src/engraving/libmscore/harmony.cpp#L1379

bkunda commented 1 year ago

Chord symbols really need some love, and the more problems I see with them, the more it seems to me that default sizing (and then providing more flexible controls to modify each chord symbol individually) is the crux of the problem.
Bumping this to a high priority for the shortlist. It would be a fix for 4.3 at the earliest.

nathan-stewart commented 9 months ago

In the current appimage, OS: Debian GNU/Linux 12 (bookworm), Arch.: x86_64, MuseScore version (64-bit): 4.2.0-233521125, revision: github-musescore-musescore-eb8d33c

Nashville Numbers formatted in Jazz chord style actually do not display modifiers or roots. If you edit the chord, the -7/ will reaapear, and it is played correctedly, but the score displays and prints incorrectly. nashville-jazz

zacjansheski commented 9 months ago

@nathan-stewart I'm not completely understanding your comment (bear in mind I don't have much experience with Nashville Numbers)

Are you saying if you put in Nashville Number "1/3" the three disappears? Can you share a video or an example score with instructions to reproduce?

nathan-stewart commented 9 months ago

The screen shot shows - all of the 2's are actually 2- and if you edit it, it will appear. I should have shown that instead of the 1/3 as some of those are bare 1 and some have a 3 root. They play correctly, but render as shown nashville_number_format_bug.zip

nathan-stewart commented 9 months ago

They render correctly in standard style - I just like the font for Jazz - I don't really need the full up style for NN.

MarcSabatella commented 9 months ago

The "-" is there, as is the /3" - they are just tiny, as noted in the original repoort.

The different "Appearance" settings were never designed to work with Nashville numbers and simply should not be used in that context. If you want to use Nashville numbers, stick to the "Standard" setting under Appearance, but then change font to MuseJazz Text if desired (in Format / Style / Text styles / Nashville number).

That said, again, I would still say it's a bug that the Appearance section affects Nashville numbers in any way at all - it's really only relevant for chord symbols.

zacjansheski commented 9 months ago

Ah, I had to zoom in to see it, thanks Marc!

Screenshot 2024-01-05 at 12 13 19 PM