search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.04k stars 2.59k forks source link

[MU4 Task] Implement colour swatch #17714

Open jessjwilliamson opened 1 year ago

jessjwilliamson commented 1 year ago

The design is ready to be implemented. This colour swatch would not be affected by the accent colour - this colour swatch enables users to assign colours to mixer channels, percussion, etc.

Link to design is sent to dev team.

image
shoogle commented 1 year ago

It would be nice to display the colour name in a tooltip as well as sending it to screen readers.

jessjwilliamson commented 1 year ago

It would be nice to display the colour name in a tooltip as well as sending it to screen readers.

I agree! Update on this task, it is not ready to implement yet (will move this) and there are more questions to solve.

bkunda commented 3 months ago

Just a thought about the UX of this (for whoever ends up implementing it).

When we get around to implementing the colour picker in specific instances, I suspect it might be better to include it as a popup rather than a dialog.

I'm thinking specifically of the new percussion panel here.

In cases where it does appear as a dialog, I think a "Done" or "Ok" button should be included as an additional mechanism for closing it.

But we can circumvent this requirement if it takes the form of a popup (where "close" will happen by clicking away from it).