search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.13k stars 2.63k forks source link

Drum editor - note symbols and stems not alligned #18337

Closed Johan-v closed 1 year ago

Johan-v commented 1 year ago

Issue type

UI bug

Bug description

When inputing notes in a percussion stave with drumset as instrument. After N the drum editor does not look right.

Steps to reproduce

  1. Edit a perscussion part with drumset as instrument

Screenshots/Screen recordings

afbeelding

MuseScore Version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 4.2.0-231810308, revision: github-musescore-musescore-fb36c11

Regression

I don't know

Operating system

Windows 10

Additional context

No response

bkunda commented 1 year ago

@cbjeukendrup do you have any clues as to when/how this came about?

zacjansheski commented 1 year ago

@igorkorsukov this first appeared three days ago. Could this have been from one of your PRs?

https://github.com/musescore/MuseScore/pull/18325#issuecomment-1614915561

asattely commented 1 year ago

@igorkorsukov this first appeared three days ago. Could this have been from one of your PRs?

#18325 (comment)

I've reset my master branch to before this commit and the issue still remains. Still searching for the culprit!

cbjeukendrup commented 1 year ago

By the way, this is only a problem on the master branch, 4.1 is fine.

asattely commented 1 year ago

This commit seems to be at least partially at fault: cd60608df71433af51c557a5862d55f2981abf53

Resetting to before this commit fixes the issue.

bkunda commented 1 year ago

By the way, this is only a problem on the master branch, 4.1 is fine.

ok thank goodness.

Let's just make sure that the changes which caused this don't make it anywhere near 4.1.

Otherwise, good call @cbjeukendrup moving it to 4.2.

cbjeukendrup commented 1 year ago

These changes won't go to 4.1 for sure; they were part of the libmscore refactoring work, which has no reason to go to 4.1. So that's a relief!

igorkorsukov commented 1 year ago

Thanks for the research, I'll take it to fix