musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.39k stars 2.68k forks source link

Acciacciatura sounds like an appoggiatura in MIDI export #18624

Open ydalton opened 1 year ago

ydalton commented 1 year ago

Issue type

Other type of issue

Bug description

When exporting a piece that uses acciacciaturas (quick grace notes) to MIDI, they are converted to something that sounds like appoggiatura.

Steps to reproduce

  1. Write a piece that uses acciacciaturas.
  2. Export to MIDI
  3. Play it back, it should give a wrong conversion.

Screenshots/Screen recordings

I write two bars, one with acciacciaturas and the next one with appoggiaturas. The first playback sounds exactly as it should.

https://github.com/musescore/MuseScore/assets/113905856/09a8eac4-87fc-4132-84b4-4c364b2e4873

In this video you can hear the erroneous MIDI conversion.

https://github.com/musescore/MuseScore/assets/113905856/2a8cf79a-110e-44f3-9074-293b3410aa2c

A close up of the test score.

Screenshot 2023-07-15 at 16 31 40

MuseScore Version

OS: macOS 13.4, Arch.: x86_64, MuseScore version (64-bit): 4.1.0-231921401, revision: github-musescore-musescore-2e3a93a

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

macOS 13

Additional context

No response

ydalton commented 1 year ago

I have been able to replicate this exact issue on a different computer using the latest Linux AppImage running on Arch Linux.

scorster commented 2 months ago

I encountered an acciaccatura issue today in MuseScore 4.4.1 on MacOS so I searched, found this related thread, and investigated.

I created the following expository materials:

In the audio file the score's four bar example phrase repeats four times:

  1. initially I adjusted the grace notes to conform to my preferred "before the beat" acciaccatura timing
  2. next you'll hear museScore's MIDI interpretation of Line 1 of the score. Note that it sounds reasonable in MuseScore but not when imported from .mid to Logic Pro X, which suggests an improper MIDI export of grace notes.)
  3. then no grace notes (like Line 2 of the score)
  4. then appogiatura (Line 3 of the score) which seems correct ... except arguably the final grace.

No. 2 is the real rub here because we hear the phrased played one way in MuseScore and very differently after MIDI import to Logic Pro. As previously stated, this is evidence of an improper MIDI export.

Steps to replicate

     • Open the attache MSS4.4.1 score      • Export to MIDI      • Open the MIDI file in a DAW

This is the MuseScore file:

MSS4-4-1 Grace Note Playback tests - Acciaccatura and Appogiatura.mscz.zip

Here's the MIDI file exported from MuseScore:

Grace Note TESTs 02.mid.zip

And this is an audio file I created in Logic Pro, after importing the .mid file:

MSS4-4-1 Grace note TESTs Acciaccatura and Appogiatura.m4a.zip

Below is an image of Logic's Piano Roll Editor—regarding No. 1 above—where in the first example you'll see grace notes clearly ahead of the main note. There's a slight intentional gaps before and after the grace note, thus emulating a picking-gap that naturally occurs when striking a string and a slight gap that occurs when "launching" the grace note.

Conclusions

• Musicians can forever opine about the proper acciaccatura grace note timing, and there's really no single answer.

• MuseScore could accommodate a variety of needs by offering properties that govern the start and end positions of grace notes, particularly acciaccaturas.

• Such features would enable exact crafting of stylistic interpretations, which would set playback to the desired outcome. This is a plus for exporting compositional "performances" from MuseScore ... and I can envision educators using the available properties to audibly illustrate the effect of various forms of acciaccatura and apoggiatura timing and various genres and periods.

Logic Pro X PRE window showing Acciaccatura and Apoggiatura Grace notes

scorster commented 2 months ago

Seems related to https://github.com/orgs/musescore/projects/48?pane=issue&itemId=63750040