musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.13k stars 2.63k forks source link

Audio export randomly skipping notes at 48000Hz #18875

Closed majenkotech closed 1 year ago

majenkotech commented 1 year ago

Issue type

Muse Sounds bug

Bug description

When exporting as WAV (or MP3 for that matter) randomly (yet predictably within a score) notes will be omitted from the export. These notes sound normally when playing the score, it's only during export that they are missing.

This score, which uses the MuseSounds Harpsichord instrument, demonstrates the problem. Load it and play it and it plays fine.

SkippedNotes.zip

But when exporting it skips a couple of notes. This phrase was copied from another score which the same problem but with different notes - when copying and pasting the notes that were skipped in export changed, so it's shouldn't be something associated with the notes themselves, but where they are in the score?

This is the export:

https://github.com/musescore/MuseScore/assets/3812892/ef9f6645-692a-4b02-94c8-5518e1771003

Steps to reproduce

Load the file and export it as WAV.

Screenshots/Screen recordings

No response

MuseScore Version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

Yes, this used to work in a previous version of MuseScore 4.x

Operating system

Windows 10

Additional context

Note that this is not just limited to Harpsichord, it does it with other instruments as well.

I'm also seeing HEAD on Linux behave in exactly the same way - same notes skipped and everything.

zacjansheski commented 1 year ago

I am unable to reproduce this, are you making any adjustments to sample rate?

majenkotech commented 1 year ago

Nope, everything is default, and it does it for both MP3 and WAV, and on different computers and operating systems.

zacjansheski commented 1 year ago

Interesting, I have tried on 3 devices: Mac OS 11.6.5, Ubuntu 20.04.6, Windows 11

Could it be specific to Windows 10?

majenkotech commented 1 year ago

If it was I wouldn't expect to see it happen on Linux (Arch)....

majenkotech commented 1 year ago

If it helps, here's the full score where I first noticed the problem. The cut-down version above is a copy-and-paste of one of the harpsichord sections from this.

Turrican_II-World1.zip

cbjeukendrup commented 1 year ago

I can't reproduce this either. Are you sure that Muse Sounds is up to date on your computer? (see Muse Hub)

majenkotech commented 1 year ago

Yep, everything is up to date (something I am in the habit of checking every time before I start working on anything).

0,146bcefa-1588-44e4-9782-59ddc78daa36,Muse Woodwinds
I,0.5.15.0
0,1707eef4-633c-413d-8b1f-725e1cdc05b8,Muse Brass
I,0.3.7.0
0,1f7e1d31-6313-4329-a6bc-987cafa7d56d,Muse Keys
I,0.4.7.0
0,54becf84-d723-4417-9c7d-7d0c0ed33596,Muse Percussion
I,0.5.2.0
0,a1531f7f-6b8d-45ee-81d5-942a329994c4,Muse Choir
I,0.3.9.0
0,c242d818-4654-41f6-8659-a8d0f5c9232b,Muse Strings
I,0.4.11.0
0,cba44cea-47bc-4c61-bf57-abcb4e998bc9,Muse Harp
I,0.2.4.0
1,audacity,Audacity
I,3.3.3.0
1,hub,Muse Hub
I,1.0.2.799
1,musesampler,MuseSampler
I,0.4.0.25
1,musescore,MuseScore
I,4.1.1.232071203
3,2f453ce4-f65e-40ff-9ca6-5383d0b32013,Reverb
I,1.0.2.0
3,335c99f7-f0dc-42c2-8c43-6f1858d43404,Simple EQ
I,1.0.2.0
3,3671a35a-276f-4d49-a1b4-d0c67bea0f49,Delay
I,1.0.2.0
3,36b3a84e-7f90-4173-9653-2da0bcda90c5,Rotary
I,1.0.3.0
3,6fa48e9a-589f-43cf-9090-28a48d7d5563,De-Ess
I,1.0.2.0
3,fb7b8dca-5ebf-4dc6-98e7-3fe016937830,Pro EQ
I,1.0.2.0

(if that means anything to anyone....)

majenkotech commented 1 year ago

I'm just setting up a spare computer with Windows 11, and noticed that export on here is defaulting to 44100Hz, whereas on my windows 10 and linux machines it defaults to 48000Hz. I'm running a test export now (it takes forever, this is an ancient computer) at 44100, and then if that works I'll do another at 48000 to see if it then fails.

majenkotech commented 1 year ago

OMG, that's totally it. It only happens at 48000Hz export, which seems to be the default on both my main computers. Maybe not the fresh-install default though. Try exporting the sample file above at 48000Hz...

MarcSabatella commented 1 year ago

See also https://github.com/musescore/MuseScore/issues/17849, and a number of other issues relating to sample rate dependencies.

cbjeukendrup commented 1 year ago

I can indeed reproduce it too when switching to 48000 Hz. Thanks for your investigation! (And the default is indeed 44100, but if you've ever switched to 48000, that will be remembered, so that might be a point of confusion here.)