search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.14k stars 2.63k forks source link

[TIED NOTES] Tied notes from first volta continues to be sustained in the second volta #19104

Open Attackoh opened 1 year ago

Attackoh commented 1 year ago

Issue type

General playback bug

Bug description

Notes that are tied to notes inside the first volta will continue to be played in the second volta.

Steps to reproduce

  1. Go to this score Lake of eternal sleep.zip
  2. Skip to 3:15. Notice bug.

This playback bug occurs in every instrument, copy and paste the F horn part to other instruments and same thing occurs.

Screenshots/Screen recordings

https://github.com/musescore/MuseScore/assets/120669196/ecf8dae4-2af1-4b1c-b8ec-1e62f855974d

MuseScore Version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

I don't know

Operating system

Windows 10

Additional context

No response

zacjansheski commented 1 year ago

Minimal example:

https://github.com/musescore/MuseScore/assets/69917893/c959c51b-0621-459b-9e33-1ecbda82ecf8

Tie+Volta.zip

zacjansheski commented 1 year ago

Not a regression, same behavior in MS3

bkunda commented 1 year ago

Will be important to stamp this one out!

wizofaus commented 4 months ago

Happy to have a look at this if you nobody else is - is it only MS Basic or Muse Sounds too?

zacjansheski commented 4 months ago

@wizofaus the issue occurs with both MS Basic and Muse Sounds

wizofaus commented 4 months ago

Thanks. Do you know if anyone has started looking at it?

zacjansheski commented 4 months ago

@RomanPudashkin have you started work on this one?

RomanPudashkin commented 3 months ago

@zacjansheski I'm not working on it, so @wizofaus you can try to fix it

wizofaus commented 3 months ago

Thanks, again, if you can assign it that'd be great.

wizofaus commented 3 months ago

Won't be trivial to fix, as the logic to determine playback duration with ties doesn't have ready access to whether it's doing it as part of a repeat or not, but will have a go.

wizofaus commented 3 months ago

Related, ties over barlines, which for the most part don't actually make sense:

image

But in principle could (but don't play back "correctly"):

image

wizofaus commented 1 month ago

Confirmed this is still happening in 4.4, and my PR still fixes the issue, but hasn't been reviewed yet (have resolved merge conflicts).