Key, Clef, Time Signature, Staff Type Change inconsistencies

[sammik]

Issue type

Engraving bug

Bug description

Lets start with score where in measure B is:

• key change
• clef change
• time change
• staff type change

Measure A is measure before B

After measure operations (removing, adding), all elements should behave same. But whats the actual status?

1) Insert measure between A and B

• key, clef, and time are moved backward, to the begining of newly added measure
• but staf type change doesn't

2) Remove measure A (measure before changes)

• key, time, and staff type chage are preserved
• but clef is not, it is removed from score

3) Remove measure B (measure with changes)

• key is removed
• clef is preserved
• changed staffType is preserved, but staff type change icon is removed
• time is preserved, if differs from preceding measure

• time is removed, if it is of same kind, as preceding one

4) Instrument Change

Now imagine, user adds Instrument change to score. All elements mentioned above (key, clef, time and staff type) are parts of Instrument change, so all of them should be preserved and palced in same point, as instrument change itself is.

So, if "move clef keys on insertion" (1) is intended behaviour, we need one of the following: 1) move also instrument change backward 2) or don't move elements, if the are "forInstrumentChange"

5) First measure

a) Remove elements

If we add all elements mentioned above to the (begining of) first measure, and trying to remove them

• key signature is not possible to remove (user is allerted to change it instead)
• clef is changed to default (for current instrument staff) one
• staff type is preserved (remains changed), but icon is removed
• time is changed to default one (4/4) but time signature is missing

https://github.com/musescore/MuseScore/assets/1646034/fbf9c17a-6378-46f6-a8ad-3b888a714ddc

b) Remove first measure

If if dont remove elements one by one, but remove first measure itself

• key is preserved
• time is preserved
• clef is changed to default one
• staff type is preserved (remains changed), but icon is removed

https://github.com/musescore/MuseScore/assets/1646034/0ee22698-bf70-4bc1-b26f-0978bc341150

MuseScore Version

master

Regression

I don't know

Operating system

Ubuntu 22.04

Additional context

No response

[sammik]

@oktophonie @bkunda

[MarcSabatella]

When inserting measures, most users seem to expect the results to be different depending on whether you insert after the bar A or before bar B. See for example https://github.com/musescore/MuseScore/issues/18149