musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.16k stars 2.64k forks source link

Crash after applying shortcut for Measure properties #19425

Open MichLeon opened 1 year ago

MichLeon commented 1 year ago

Issue type

Crash or freeze

Bug description

Assign a shortcut to Measure properties, e.g. Ctrl + Alt + M Select a note. Apply shortcut. Crash.

Steps to reproduce

  1. In Preferences > Shortcuts assign a shortcut to Measure properties, e.g. Ctrl + Alt + M
  2. Select a note.
  3. Apply shortcut.

Screenshots/Screen recordings

No response

MuseScore Version

MuseScore version (64-bit): 4.1.1-232071203, revision: -e4d1ddf

Regression

No.

Operating system

Windows 11

Additional context

MuseScore_230916_181459.log

MichLeon commented 1 year ago

came up on https://musescore.org/en/node/351668

vashutangri commented 1 year ago

Hey, would love to work on this!

Jojo-Schmitz commented 10 months ago

I can't reproduce the crash. But the measure properties dialog doesn't show either, not even when selecting a measure rather than a note. Mu3 doesn't have that issue BTW, but it doesn't have (the option to assign) a shortcut for measure properties

vashutangri commented 8 months ago

Hey, so I wanted to add that the problem I was facing when I tried working on this was different. If you use another shortcut (Ctrl+Alt+W) then it works and the dialog opens while assigning Ctrl+Alt+M to anything, not just measure/staff properties, doesn't work (atleast for me). Is this the same for everyone? Also would love a hint as to where to look to solve this issue

wizofaus commented 6 months ago

Definitely crashes for me in debug build anyway, and had similar problem myself. Will change so that using "Measure properties" automatically selects the whole measure based on what's selected if I can.

Jojo-Schmitz commented 6 months ago

Could this be related to #22246 ?

wizofaus commented 1 month ago

Have confirmed crash still occurs in 4.4 (not just debug build either), and updated PR that fixes it.

wizofaus commented 2 hours ago

This crash is still happening, and I just lost work because of it (was using 4.4.2 at the time). It's been P1 since September last year and my PR has been sitting there for quite some time. @zacjansheski