Incomplete Undo for several actions

adnominatio commented 10 months ago

Issue type

Choose option...

Bug description

Musescore 4 "undo" action results in incomplete or incorrect results. The following issues have been found:

When a lyric block & (one other feature, eg lyric in different verse, slur) is moved with x, undo fails to restore the lyric to the correct place. The lyric ends up in the middle of the staff (see image in Screenshots). It can be returned to the original position by hitting x twice (swapping position twice). This effect occurs for above-staff lyrics and below-staff lyric blocks.
When a lyric block is deleted, "undo" does not restore hyphens properly. Hyphenation after the lyric block restores properly, but preceding hyphenation does not come back.

Steps to reproduce

Steps to reproduce are in the bug description. This bus occur after software close and reopen, and after computer restart.

Screenshots/Screen recordings

Lyric placement bug when undoing lyric + (other) move with x Lyric placement when undoing lyric + (other) move with x

_ Hyphenation bug:

Hyphenation before delete

Measure after delete

Measure after undo, with preceding hyphen missing

MuseScore Version

OS: Windows 10 Version 2009 or later, Arch.: x86_64, MuseScore version (64-bit): 4.1.1-232071203, revision: github-musescore-musescore-e4d1ddf

Regression

Yes, worked in 4.0.2, broken in 4.1.0

Operating system

Windows 11

Additional context

No response

zacjansheski commented 10 months ago

Thank you for logging this! The first two issues are regressions that occurred between 4.0.2 and 4.1.0

I haven't reproduced the third issue - "When an adjustment or change results in a staff being pushed to the next page, "undo" does not move the staff back. Returning the page to its previous form requires something to adjust the position of a block. Also, going to Page Settings and changing the size up/down and then back down/up moves the system back to the previous page."

Maybe I don't completely understand, could you provide a screen share reproducing that one?

bkunda commented 2 months ago

I too could not reproduce the third issue in current master, but the first two issues remain. These are likely enough to warrant a dedicated fix, particularly as they are both related to lyrics (and the UX of working with them).

bkunda commented 2 months ago

Adding "needs review" because the priority label might be reconsidered. This is now a fairly old issue, so we need to assess it against other P1s if it is to be fixed in 4.4.

adnominatio commented 2 months ago

Problems 1 and 2 are still issues. One thing I did notice that was very weird is that these may only be visual in some fashion. Musescore obviously doesn't recognize these as changed or it wouldn't have "undone" to them. If you make one of these changes and you get the reported problem (hyphen doesn't return or note ends up in the middle line), they return to normal after you save, close, and reopen. Because I didn't want to mess with one of my existing scores, I can say only that this is true for at least 1-3 changes.

I haven't been composing a lot lately, so I don't know if #3 is fixed or not. I couldn't reproduce it just now, but I'm also not formatting something complicated and cursing Musescore for it.

As a side comment regarding lyrics, it would be fantastic if musescore could implement a "drag laterally" or "drag vertically" option so you could adjust something sideways and have it not go up or down too. This is something that powerpoint has had forever, for example, and Sibelius does as well (drag + control/shift). Sometimes the lyrics just aren't where I want them and I then don't want to have to worry about adjusting them up or down, especially as the arrow key does weird things to lyrics.

zacjansheski commented 2 months ago

Let's remove the third point from this issue.

For a feature request regarding dragging lyrics, please open a new report, but shift drag and Command drag do already work for that(?)

Thank you!

musescore / MuseScore