musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.06k stars 2.6k forks source link

No natural is added to the next note when adding microtonal accidental (as opposed to normal accidental) #20162

Open cbjeukendrup opened 9 months ago

cbjeukendrup commented 9 months ago

Issue type

UX/Interaction bug (incorrect behaviour)

Bug description

No response

Steps to reproduce

  1. Create score
  2. Add same-pitched notes in one measure
  3. Apply a microtonal accidental to the first of them

Expected: the accidental only applies to the first note, and thus the next note receives a "natural" accidental Actual: the accidental applies indeed only to the first note (playback-wise), but no natural is added

Screenshots/Screen recordings

No response

MuseScore Version

master

Regression

No.

Operating system

*

Additional context

No response

sammik commented 9 months ago

This is because there is in fact no real support for microtonal accidentals yet.

All notes with microtonal accidentals has accidental state natural.

There are only 5 states at the moment, I think.

If we want to support all microtonal accidentals, wee need state for each one. (Or alternatively we can do something, like Dorico - defining custom tonal spaces with only selected accidentals, and their states. Me, as user would prefer first option.)

Jojo-Schmitz commented 9 months ago

The metadata, the (default) cent offset of these microtonal accidentals, is available in the code, just absolutley nothing that makes use of it.

See also #19805, esp. https://github.com/musescore/MuseScore/pull/19805#issuecomment-1775154198for the bad effects that may happen when changing them away from natural

sammik commented 9 months ago

The metadata, the (default) cent offset of these microtonal accidentals, is available in the code, just absolutley nothing that makes use of it.

Cent offset metadata in theory may be used to fix this one issue, but it is not enough for many other.

Because many different accidentals with same cent offset exist there (quartertone Gould, or Stein - Zimmermann), we still need individual state for each one - if we have "accidentalQuarterToneSharpStein C" in score and we add another "accidentalQuarterToneSharpStein C" in same measure, it should show without accidental. But if we add "accidentalQuarterToneSharpArrowDown C", it should show with accidental, even if it has same cent offset as accidentalQuarterToneSharpStein.

Jojo-Schmitz commented 9 months ago

Actually the (default) cent offset of these microtonal accidentals nowadays is used!

cbjeukendrup commented 9 months ago

For playback, yes. Apparently Roman sneaked that in in some PR related to bends playback :)

Jojo-Schmitz commented 9 months ago

Yes, 'sneaked in' is the word here ;-) It is very good though, finally after all therse years that info is actually getting used!

lgvr123 commented 5 months ago

Could it be related to this bug Microtonal Key signatures ?