search

musescore / MuseScore

MuseScore is an open source and free music notation software. For support, contribution, bug reports, visit MuseScore.org. Fork and make pull requests!
https://musescore.org
Other
12.08k stars 2.61k forks source link

MuseScore doesn't detect if score to upload is replaceable on second publish #20544

Open XiaoMigros opened 9 months ago

XiaoMigros commented 9 months ago

Issue type

Cloud issue (opening, saving, logging in/out)

Bug description

Title is a mouthful, explained steps below:

Steps to reproduce

  1. Open a score, with an empty 'source property'.
  2. Open 'File > Publish to MuseScore.com', then press 'Cancel'.
  3. Go to File > Project properties.
  4. Paste a valid MuseScore.com score URL in the Source field.
  5. Open 'File/Publish to MuseScore.com' again; there is no option to replace the existing score.

Screenshots/Screen recordings

No response

MuseScore Version

4.2.0

Regression

I don't know

Operating system

Windows 10

Additional context

No response

cbjeukendrup commented 3 months ago

Under the hood, this is related to https://github.com/musescore/MuseScore/issues/17561.

The problem is that there is no good single source of truth for the source URL. For this issue, my (unverified) guess would be that using the project properties dialog only affects the version stored in Score::m_metaTags, and not the one in NotationProject::m_cloudInfo, while the latter is used to determine to which .com score the score is linked.

I'm not 100% sure yet what's the best way to solve this problem; but I'm quite sure that we should no longer store the cloud score url in the metaTags thing, but only in a single dedicated place. I also have some worries about how the ability to manually modify the cloud score URL will interfere with "revision IDs". We'll need to think about that.